[8.x] Ignore max attempts if retryUntil is set#35214
Merged
taylorotwell merged 1 commit intolaravel:8.xfrom Nov 13, 2020
Merged
[8.x] Ignore max attempts if retryUntil is set#35214taylorotwell merged 1 commit intolaravel:8.xfrom
taylorotwell merged 1 commit intolaravel:8.xfrom
Conversation
Member
|
It looks like maxExceptions will still be respected? If that is the case I don't have a big problem with this change. |
Member
Author
|
No behaviour change around |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if a job fails due to an exception and
retryUntiltime has not passed yet, the worker will check formaxAttempts. However, if the job was released andretryUntilhas not passed yet, the worker will not check formaxAttempts.The PR unifies the behaviour. So with this PR, if a
retryUntilis set the worker is going to ignoremaxAttemptscompletely.Solves #35199