[10.x] Improve typehint for Model::getConnectionResolver()#47749
Merged
taylorotwell merged 1 commit intolaravel:10.xfrom Jul 15, 2023
LukeTowers:patch-1
Merged
[10.x] Improve typehint for Model::getConnectionResolver()#47749taylorotwell merged 1 commit intolaravel:10.xfrom LukeTowers:patch-1
taylorotwell merged 1 commit intolaravel:10.xfrom
LukeTowers:patch-1
Conversation
static::$resolver can be null, either before Model::setConnectionResolver() is called or after Model::unsetConnectionResolver() is called.
LukeTowers
added a commit
to wintercms/storm
that referenced
this pull request
Jul 14, 2023
GrahamCampbell
changed the title
GrahamCampbell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
static::$resolvercan be null, either beforeModel::setConnectionResolver()is called or afterModel::unsetConnectionResolver()is called.Running into an issue with static analysis complaining about this: https://github.com/wintercms/storm/actions/runs/5558377553/jobs/10153396089#step:10:16