Fix manifest handling in SSR mode#13
Merged
Merged
Conversation
timacdonald
reviewed
Jun 14, 2022
timacdonald
force-pushed
the
fix-ssr-build
branch
from
662a8ab to
868ab9a
Compare
Member
|
casually force pushing to your branch 😬 |
timacdonald
reviewed
Jun 14, 2022
| return path.join(config.publicDirectory, config.buildDirectory) | ||
| } | ||
|
|
||
| function resolveManifestConfig(config: ResolvedConfig): string|false |
Member
There was a problem hiding this comment.
This false return type is dedicated to @michaeldyrynda ❤️
Member
Author
|
Changes look good! |
timacdonald
approved these changes
Jun 14, 2022
Member
timacdonald
left a comment
timacdonald
left a comment
There was a problem hiding this comment.
@jessarcher I've made some tweaks to accommodate the differing manifest filename in ssr mode, when just passing true.
Would love you to re-review before we merging.
Member
|
haha. beat me to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manifest augmentation added in #9 broke SSR builds because the manifest file isn't typically created in this mode.
This PR addresses this by only augmenting the manifest when the manifest is enabled for the build.
It will also now use the manifest name from the resolved config if it exists.