Exclude default Laravel directories from dev server file watcher#349
Open
natsuki-engr wants to merge 1 commit into
Open
Exclude default Laravel directories from dev server file watcher#349natsuki-engr wants to merge 1 commit into
natsuki-engr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a default
server.watch.ignoredconfiguration that excludes Laravel directories which commonly cause unnecessary full page reloads during development:bootstrapdatabasestoragetestsvendorMotivation
Multiple users have reported that Vite triggers unexpected page reloads when files change in directories like
storage/framework/viewsorvendor(#324, #152, laravel/laravel#6500). @timacdonald outlined a preferred approach in laravel/laravel#6500 (comment) — handle this in the plugin with sensible defaults and an escape hatch.Resolves #152
Related: #324, laravel/laravel#6500
Approach
public/vendorare not affected.server.watch.ignored, the plugin does not override it.refreshconfig (e.g.storage/framework/views/**) are automatically excluded from the ignore list so they remain watched.serve, notbuild.Added Tests
server.watch.ignoredconfig