Skip to content

fix:add approval capability to README#224

Merged
liangshuo-1 merged 1 commit intolarksuite:mainfrom
zhaoshengmeng626:fix/approval_description_modify
Apr 2, 2026
Merged

fix:add approval capability to README#224
liangshuo-1 merged 1 commit intolarksuite:mainfrom
zhaoshengmeng626:fix/approval_description_modify

Conversation

@zhaoshengmeng626
Copy link
Copy Markdown
Contributor

@zhaoshengmeng626 zhaoshengmeng626 commented Apr 2, 2026

Summary

Update README.md and README.zh.md: add Approval to the Features table

Changes

  • Update README.md and README.zh.md: add Approval to the Features table,bump domain count to 12 and skill count to 20
  • fix approval service descriptions

Summary by CodeRabbit

  • Documentation
    • Updated feature metrics: AI Agent Skills count increased to 20 and business domain coverage to 12.
    • Added an “✍️ Approval” capability (EN/ZH) covering querying approval tasks, approve/reject/transfer, withdraw and CC operations.
    • Adjusted Markdown table formatting for Features and Agent Skills for improved alignment/spacing.
    • Refined displayed service name for Approval for clearer presentation.

@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label Apr 2, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 2, 2026

📝 Walkthrough

Walkthrough

Updated English and Chinese documentation to add a new "Approval" AI Agent capability, adjust counts and table formatting; renamed the approval service title in registry metadata (internal/registry/service_descriptions.json) for both locales.

Changes

Cohort / File(s) Summary
Documentation (English & Chinese)
README.md, README.zh.md
Added a new "✍️ Approval" / “✍️ 审批” capability and lark-approval skill; bumped AI Agent Skills 19→20 and business domains 11→12; adjusted Markdown table spacing/alignment in features and agent-skills tables.
Service Registry Metadata
internal/registry/service_descriptions.json
Renamed approval service title fields: English "Approval API""Approval", Chinese "审批 API""审批"; descriptions unchanged.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • feat: add approve domain #217: Modifies/introduces the approval skill and registry entries; strongly related to README and service_descriptions.json edits.

Suggested reviewers

  • liangshuo-1
  • MaxHuang22

Poem

🐰 I hopped through lines to add a name,

Twenty skills now join the game,
Twelve domains give a cheerful cheer,
Approval's here — a tiny cheer! 🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description covers Summary and Changes sections but is missing the Test Plan and Related Issues sections specified in the template. Add Test Plan section with test verification details and Related Issues section to complete the description according to the template format.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The pull request title accurately describes the main change: adding the Approval capability to README files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 2, 2026

Greptile Summary

This PR is a documentation-only update that adds the new ✍️ Approval capability to the Features and Agent Skills tables in both the English and Chinese READMEs, bumps the domain count from 11 to 12 and the skill count from 19 to 20, and removes the redundant " API" suffix from the Approval service title in service_descriptions.json.

Confidence Score: 5/5

Safe to merge — purely documentation changes with no functional impact.

All changes are documentation-only (README files and a JSON display-name field). The only finding is a P2 capitalization nit in the lark-approval skill description, which does not block merge.

No files require special attention.

Important Files Changed

Filename Overview
README.md Adds ✍️ Approval row to Features table, adds lark-approval to Agent Skills table, bumps domain count to 12 and skill count to 20; minor capitalization inconsistency in the lark-approval description.
README.zh.md Chinese equivalent of README.md changes — adds 审批 row to features table and lark-approval to skills table, updates counts to 12 domains / 20 skills. Looks correct and consistent.
internal/registry/service_descriptions.json Removes the redundant " API" suffix from the Approval English title ("Approval API" → "Approval"), consistent with other entries such as Base, Calendar, etc.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["README.md / README.zh.md"] -->|"Add ✍️ Approval row"| B["Features Table\n(12 domains)"]
    A -->|"Add lark-approval row"| C["Agent Skills Table\n(20 skills)"]
    D["service_descriptions.json"] -->|"'Approval API' → 'Approval'"| E["Display Title\n(en/zh)"]
Loading

Reviews (4): Last reviewed commit: "fix:add approval capability to README" | Re-trigger Greptile

liangshuo-1
liangshuo-1 previously approved these changes Apr 2, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@README.md`:
- Around line 15-16: The README has inconsistent skill counts: the header lines
"Agent-Native Design" and "Wide Coverage" claim 20 Skills while the Skills table
and Line 9 show 19; fix by making the numbers consistent — either add the
missing 20th skill row to the Skills table (ensure its title and link format
matches existing entries) or change both header lines to say 19, and update any
other occurrences (search for "20 structured [Skills]" and "20 AI Agent
[Skills]") so all references (headers and the Skills table) use the same count.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 365d4468-355d-4258-81cd-3dfc71ea4615

📥 Commits

Reviewing files that changed from the base of the PR and between 6692300 and 4c70423.

📒 Files selected for processing (3)
  • README.md
  • README.zh.md
  • internal/registry/service_descriptions.json

Comment thread README.md
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@4c70423dd7a917ab8b42a22081b7966c699566e0

🧩 Skill update

npx skills add zhaoshengmeng626/lark-cli#fix/approval_description_modify -y -g

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@README.zh.md`:
- Line 9: The README line claiming "20 个 AI Agent [Skills](./skills/)" is
inconsistent with the Skills table which lists 19 entries; either change that
phrase to "19 个 AI Agent [Skills](./skills/)" or add the missing skill entry to
the Skills table so counts match. Locate the exact string "20 个 AI Agent
[Skills](./skills/)" in README.zh.md and update it, or add the missing skill row
to the Skills table (the skills list/entries) so the total becomes 20 and the
document is consistent.
- Line 16: Update the phrase "12 大业务域、200+ 精选命令、 20 个 AI Agent [Skills]" to
match the actual Skills table count and spacing: change "20" to "19" so it reads
"12 大业务域、200+ 精选命令、19 个 AI Agent [Skills]" and remove the extra space after the
punctuation (、) to ensure consistent spacing across the document; locate and
edit the exact string in README.zh.md.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9781d296-cf7a-4115-9146-3266d308298d

📥 Commits

Reviewing files that changed from the base of the PR and between 4c70423 and a83d07c.

📒 Files selected for processing (3)
  • README.md
  • README.zh.md
  • internal/registry/service_descriptions.json
✅ Files skipped from review due to trivial changes (1)
  • internal/registry/service_descriptions.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • README.md

Comment thread README.zh.md
Comment thread README.zh.md
@zhaoshengmeng626 zhaoshengmeng626 force-pushed the fix/approval_description_modify branch from a83d07c to 99878a6 Compare April 2, 2026 11:51
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 2, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (1)
README.zh.md (1)

16-16: ⚠️ Potential issue | 🟡 Minor

Remove the extra space after punctuation in the coverage bullet.

Line 16 has 、 20 (extra space after ), which is inconsistent with adjacent Chinese punctuation style.

✏️ Proposed fix
-- **覆盖面广** — 12 大业务域、200+ 精选命令、 20 个 AI Agent [Skills](./skills/)
+- **覆盖面广** — 12 大业务域、200+ 精选命令、20 个 AI Agent [Skills](./skills/)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@README.zh.md` at line 16, The bullet in README.zh.md contains an extra space
after the punctuation in the text "12 大业务域、200+ 精选命令、 20 个 AI Agent
[Skills](./skills/)"; edit that line to remove the space after the Chinese comma
so it reads "12 大业务域、200+ 精选命令、20 个 AI Agent [Skills](./skills/)" to match
Chinese punctuation spacing style.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@README.zh.md`:
- Line 16: The bullet in README.zh.md contains an extra space after the
punctuation in the text "12 大业务域、200+ 精选命令、 20 个 AI Agent [Skills](./skills/)";
edit that line to remove the space after the Chinese comma so it reads "12
大业务域、200+ 精选命令、20 个 AI Agent [Skills](./skills/)" to match Chinese punctuation
spacing style.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 57b11684-8922-4770-9191-e8763c8b88ab

📥 Commits

Reviewing files that changed from the base of the PR and between a83d07c and 99878a6.

📒 Files selected for processing (3)
  • README.md
  • README.zh.md
  • internal/registry/service_descriptions.json
✅ Files skipped from review due to trivial changes (1)
  • internal/registry/service_descriptions.json

@zhaoshengmeng626 zhaoshengmeng626 changed the title fix:modify readme description fix:Add Approval capability to README features Apr 2, 2026
@zhaoshengmeng626 zhaoshengmeng626 force-pushed the fix/approval_description_modify branch from 99878a6 to 0331966 Compare April 2, 2026 11:57
@zhaoshengmeng626 zhaoshengmeng626 changed the title fix:Add Approval capability to README features fix:add approval capability to README Apr 2, 2026
@liangshuo-1 liangshuo-1 merged commit bf537f8 into larksuite:main Apr 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants