chore: add missing license headers#352
Conversation
Change-Id: Ic26bedcbb111331eb53d695fccdabd0907a6272f
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (20)
📝 WalkthroughWalkthroughAdds copyright and MIT SPDX license identifiers to the top of 20 files across cmd, extension, internal, and scripts directories. No functional code, logic, or control flow was modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Greptile SummaryThis PR adds the standard Confidence Score: 5/5Safe to merge — purely additive license header changes with no logic modifications. All 20 files receive the correct, repo-standard MIT header. The copyright year (2026), SPDX identifier, and header placement (including ordering relative to //go:build constraints) are fully consistent with the rest of the codebase. No logic is touched. No files require special attention.
|
| Filename | Overview |
|---|---|
| cmd/auth/login_result.go | License header added; no logic changes. |
| cmd/auth/login_scope_cache.go | License header added; no logic changes. |
| cmd/auth/login_scope_cache_test.go | License header added; no logic changes. |
| cmd/auth/login_strict_test.go | License header added; no logic changes. |
| extension/credential/env/env_test.go | License header added; no logic changes. |
| extension/credential/registry_test.go | License header added; no logic changes. |
| internal/credential/types.go | License header added; no logic changes. |
| internal/credential/credential_provider_test.go | License header added; no logic changes. |
| internal/credential/default_provider_test.go | License header added; no logic changes. |
| internal/credential/integration_test.go | License header added; no logic changes. |
| internal/credential/types_test.go | License header added; no logic changes. |
| internal/keychain/auth_log_test.go | License header added; no logic changes. |
| internal/keychain/keychain_darwin_test.go | License header added before //go:build darwin constraint, matching existing repo pattern. |
| internal/keychain/keychain_other_test.go | License header added before //go:build linux constraint, matching existing repo pattern. |
| internal/vfs/default.go | License header added; no logic changes. |
| internal/vfs/fs.go | License header added; no logic changes. |
| internal/vfs/osfs.go | License header added; no logic changes. |
| internal/vfs/osfs_test.go | License header added; no logic changes. |
| scripts/issue-labels/index.js | License header added to JS file; no logic changes. |
| scripts/issue-labels/test.js | License header added to JS file; no logic changes. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR: Add Missing License Headers] --> B{File Type}
B --> C[Go Files - 18 files]
B --> D[JavaScript Files - 2 files]
C --> E[cmd/auth/*.go]
C --> F[extension/credential/**/*.go]
C --> G[internal/credential/*.go]
C --> H[internal/keychain/*_test.go]
C --> I[internal/vfs/*.go]
D --> J[scripts/issue-labels/*.js]
E & F & G & H & I & J --> K[Standard MIT Header Added]
H --> L[Build-tagged files: header placed before go:build, consistent with repo convention]
Reviews (1): Last reviewed commit: "chore: add missing license headers" | Re-trigger Greptile
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@82601a69b3db016301ba7f6ddca075eb7f65ee9c🧩 Skill updatenpx skills add larksuite/cli#license-headers -y -g |
Summary
Adds missing repository-standard MIT license headers to files covered by the license-header check.
Changes
Test Plan
make unit-testmake testgo mod tidy(nogo.mod/go.sumchanges)go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.6 run --new-from-rev=origin/maingit diff --check*.go,*.js, and*.pyRelated Issues
Summary by CodeRabbit
Release Notes