fix: return raw base field and view responses#378
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR removes data simplification helper functions and updates response payload formats across field, view, and table operations to return raw data structures instead of simplified/transformed versions. Response structures are being standardized with consistent output formatting. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
79cf469 to
91ce040
Compare
There was a problem hiding this comment.
kongenpei has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@91ce0402d2ee87f07fbaa92bd1dd60a4b4e3df4a🧩 Skill updatenpx skills add larksuite/cli#fix-table-resp -y -g |
Summary
Return raw field and view payloads from Base read shortcuts so list responses match the upstream API shape instead of adding shortcut-specific envelope fields and normalized key names.
Changes
simplifyFieldsandsimplifyViewsand return raw field/view objects from+field-list,+view-list, and+table-getfields/viewsplustotal, and drop CLI-addeditems,offset,limit, andcountTest Plan
lark xxxcommand works as expectedmake unit-testgo mod tidy(no changes togo.modorgo.sum)GOFLAGS=-buildvcs=false go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.6 run --new-from-rev=origin/main~/.local/bin/lark-cli, then verifiedbase +field-list,base +view-list, andbase +table-getagainst a live Base tableRelated Issues
Summary by CodeRabbit