Skip to content

fix(calendar): add default video meeting to +create#383

Merged
calendar-assistant merged 1 commit intomainfrom
fix/calendar-create-vchat-default
Apr 10, 2026
Merged

fix(calendar): add default video meeting to +create#383
calendar-assistant merged 1 commit intomainfrom
fix/calendar-create-vchat-default

Conversation

@calendar-assistant
Copy link
Copy Markdown
Collaborator

@calendar-assistant calendar-assistant commented Apr 10, 2026

Summary

Make calendar +create include a default Feishu video meeting in the created event payload.
This keeps the shortcut behavior aligned with expected default meeting creation behavior.

Changes

  • Add default vchat: {"vc_type": "vc"} to the event payload built by calendar +create
  • Add a regression test covering the default vchat payload
  • Update the calendar skill reference to document the new default behavior

Test Plan

  • Unit tests pass
  • Manual local verification confirms the lark xxx command works as expected

Related Issues

  • None

Summary by CodeRabbit

Release Notes

  • New Features

    • Calendar events now automatically include a Feishu video meeting capability by default.
  • Documentation

    • Updated documentation to clarify the default video meeting setting and options for other meeting types.
  • Tests

    • Added test coverage for the default video meeting configuration.

Change-Id: Ib3ee2f393a7b81f37f5d736c009235f9acefe9f9
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions Bot added domain/calendar PR touches the calendar domain size/M Single-domain feat or fix with limited business impact labels Apr 10, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b321ec67-995a-4645-9e15-1f20a5c42ea0

📥 Commits

Reviewing files that changed from the base of the PR and between 5f3915b and 94591e1.

📒 Files selected for processing (3)
  • shortcuts/calendar/calendar_create.go
  • shortcuts/calendar/calendar_test.go
  • skills/lark-calendar/references/lark-calendar-create.md

📝 Walkthrough

Walkthrough

A default video chat field with type "vc" is added to calendar event creation payload. A corresponding unit test validates this behavior, and documentation is updated to explain the new default configuration for Feishu video meetings.

Changes

Cohort / File(s) Summary
Calendar Event Creation
shortcuts/calendar/calendar_create.go
Added vchat field with default value {"vc_type":"vc"} to the event data payload in buildEventData.
Unit Tests
shortcuts/calendar/calendar_test.go
Added new test TestBuildEventData_DefaultVChat to verify the default vchat field is correctly set to {"vc_type":"vc"}.
Documentation
skills/lark-calendar/references/lark-calendar-create.md
Updated "推荐命令" section to document that video chat is automatically configured with default vchat: {"vc_type": "vc"} for Feishu video meetings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A field hops in, so small and neat,
With vchat making meetings complete,
Video calls now automatic and true,
Tests verify what the code will do! 📹✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding a default video meeting to the calendar +create command.
Description check ✅ Passed The description follows the repository template with all required sections completed: Summary, Changes, Test Plan, and Related Issues.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/calendar-create-vchat-default

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 10, 2026

Greptile Summary

This PR adds vchat: {"vc_type": "vc"} as a hardcoded default to the buildEventData function, so all events created via the +create shortcut now include a Feishu video meeting automatically. A focused unit test and a documentation update accompany the change.

Confidence Score: 5/5

Safe to merge — the change is minimal, correctly typed, tested directly, and documented.

All findings are P2 or lower. The one-line payload addition is straightforward, a dedicated unit test validates the new field, and the documentation is updated consistently. No logic errors, security concerns, or breaking changes were found.

No files require special attention.

Important Files Changed

Filename Overview
shortcuts/calendar/calendar_create.go Single-line addition of vchat field to buildEventData; correct map type, clean insertion point.
shortcuts/calendar/calendar_test.go New TestBuildEventData_DefaultVChat test directly validates the added field; test setup is minimal but sufficient for the unit under test.
skills/lark-calendar/references/lark-calendar-create.md Documentation accurately reflects the new default vchat behavior and directs users to the full API for overrides.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["+create shortcut invoked"] --> B["buildEventData()"]
    B --> C["summary, description, start_time, end_time\nattendee_ability, free_busy_status\nreminders: [{minutes: 5}]\nvchat: {vc_type: 'vc'} ← NEW"]
    C --> D{rrule set?}
    D -- yes --> E["append recurrence field"]
    D -- no --> F["POST /calendars/:id/events"]
    E --> F
    F --> G{attendee-ids set?}
    G -- yes --> H["POST .../attendees"]
    H --> I{success?}
    I -- yes --> J["Output event_id, summary, start, end"]
    I -- no --> K["DELETE event (rollback)"]
    G -- no --> J
Loading

Reviews (1): Last reviewed commit: "fix(calendar): add default video meeting..." | Re-trigger Greptile

@github-actions
Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@94591e1bf443542841af63cf510c97597ba1de10

🧩 Skill update

npx skills add larksuite/cli#fix/calendar-create-vchat-default -y -g

@calendar-assistant calendar-assistant merged commit 6ec19cb into main Apr 10, 2026
16 of 18 checks passed
@calendar-assistant calendar-assistant deleted the fix/calendar-create-vchat-default branch April 10, 2026 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/calendar PR touches the calendar domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants