Skip to content

docs: route past meeting queries to lark-vc#482

Merged
calendar-assistant merged 1 commit intomainfrom
docs/lark-calendar-past-meeting-routing
Apr 15, 2026
Merged

docs: route past meeting queries to lark-vc#482
calendar-assistant merged 1 commit intomainfrom
docs/lark-calendar-past-meeting-routing

Conversation

@calendar-assistant
Copy link
Copy Markdown
Collaborator

@calendar-assistant calendar-assistant commented Apr 15, 2026

Summary

Clarify the routing rule between lark-calendar and lark-vc for meeting-related requests.
This makes past meeting queries go to meeting records, while keeping calendar/event and future meeting queries in lark-calendar.

Changes

  • Add an intent-routing rule to skills/lark-calendar/SKILL.md for past meeting queries
  • Document that past meeting lookups should prefer lark-vc because calendar-only data can be incomplete
  • Keep future meeting and explicit calendar/event queries handled by lark-calendar

Test Plan

  • Unit tests pass (make unit-test)
  • Manual local verification confirms the behavior works as expected

Related Issues

  • None

Summary by CodeRabbit

  • New Features
    • Improved intelligent routing for meeting and calendar queries: past meeting searches are now directed to meeting records, while future scheduling requests continue through the calendar feature for better accuracy and efficiency.

Change-Id: Ia39721ba7b72e08f29422354eb2c82c89c5b81b0
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions Bot added domain/calendar PR touches the calendar domain size/M Single-domain feat or fix with limited business impact labels Apr 15, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 15, 2026

📝 Walkthrough

Walkthrough

This change adds explicit intent routing rules to the lark-calendar skill documentation. It directs past-meeting queries to the lark-vc skill while reserving future-time and calendar/schedule requests for lark-calendar, clarifying the skill's responsibility boundaries.

Changes

Cohort / File(s) Summary
Intent Routing Documentation
skills/lark-calendar/SKILL.md
Added routing rules clarifying that past meeting queries ("yesterday", "last week") should be handled by lark-vc skill, while calendar/schedule requests and future-time arrangements remain under lark-calendar skill responsibility.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

domain/calendar, size/M

Suggested reviewers

  • hugang-lark
  • zhicong666-bytedance

Poem

🐰 A calendar's wisdom, clear as morning dew,
Past meetings to VC, where history is true,
Future plans stay home, in the calendar's keep,
Routing rules now guide us, no more doubts to reap! 📅✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding routing logic for past meeting queries to lark-vc.
Description check ✅ Passed The description follows the template with all required sections present: Summary, Changes, Test Plan, and Related Issues; all sections are complete and substantive.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/lark-calendar-past-meeting-routing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
skills/lark-calendar/SKILL.md (1)

17-19: Consider aligning terminology with lark-vc for consistency.

The routing logic is sound and correctly delegates past meeting queries to lark-vc. However, the term "过去时间的会议" (meetings at past times) could be more precise.

The lark-vc documentation consistently uses "已结束的会议" or "历史会议记录" (ended meetings / historical meeting records), which more accurately describes what vc +search retrieves—meetings that have actually concluded, not just meetings scheduled for past times.

Consider refining line 18 to better align with lark-vc's terminology and include additional examples from lark-vc's documented trigger expressions:

-**查询过去时间的会议**:如果用户明确查询过去时间的会议(如"昨天的会议"、"上周的会议"),**优先使用 [`../lark-vc/SKILL.md`](../lark-vc/SKILL.md) 搜索会议记录**。因为会议数据不仅包含从日程发起的视频会议,还包含即时会议,仅查询日程数据会导致结果不全。
+**查询已结束的会议**:如果用户明确查询已结束或历史会议(如"昨天的会议"、"上周的会议"、"今天开过的会"、"最近参加过哪些会"),**优先使用 [`../lark-vc/SKILL.md`](../lark-vc/SKILL.md) 搜索会议记录**。因为会议数据不仅包含从日程发起的视频会议,还包含即时会议,仅查询日程数据会导致结果不全。

This change improves clarity by:

  • Using "已结束的会议" to match lark-vc's terminology
  • Adding examples that align with lark-vc's documented trigger expressions ("今天开过的会"、"最近参加过哪些会")

Based on learnings from lark-vc/SKILL.md routing rules: "如果用户在问'开过的会''今天开了哪些会''最近参加过什么会''已结束的会议''历史会议记录',优先使用 vc +search。"

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@skills/lark-calendar/SKILL.md` around lines 17 - 19, Update the routing
wording in SKILL.md: replace the phrase "过去时间的会议" with the lark-vc aligned terms
"已结束的会议" or "历史会议记录" and add example trigger expressions such as "今天开过的会" and
"最近参加过哪些会" so the line that currently directs past-meeting queries to
../lark-vc/SKILL.md matches lark-vc terminology and examples; keep the existing
rule that past/ended meeting queries route to lark-vc while
calendar/scheduled/future queries remain in lark-calendar.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@skills/lark-calendar/SKILL.md`:
- Around line 17-19: Update the routing wording in SKILL.md: replace the phrase
"过去时间的会议" with the lark-vc aligned terms "已结束的会议" or "历史会议记录" and add example
trigger expressions such as "今天开过的会" and "最近参加过哪些会" so the line that currently
directs past-meeting queries to ../lark-vc/SKILL.md matches lark-vc terminology
and examples; keep the existing rule that past/ended meeting queries route to
lark-vc while calendar/scheduled/future queries remain in lark-calendar.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a0729495-0cce-4549-b325-15ead12a6fb9

📥 Commits

Reviewing files that changed from the base of the PR and between 74e4a97 and 501f859.

📒 Files selected for processing (1)
  • skills/lark-calendar/SKILL.md

@github-actions
Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@501f859c9275fab0037468f2fdcb254025ba411a

🧩 Skill update

npx skills add larksuite/cli#docs/lark-calendar-past-meeting-routing -y -g

@calendar-assistant calendar-assistant merged commit 0c7a930 into main Apr 15, 2026
10 of 11 checks passed
@calendar-assistant calendar-assistant deleted the docs/lark-calendar-past-meeting-routing branch April 15, 2026 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/calendar PR touches the calendar domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants