docs: route past meeting queries to lark-vc#482
Conversation
Change-Id: Ia39721ba7b72e08f29422354eb2c82c89c5b81b0
|
|
📝 WalkthroughWalkthroughThis change adds explicit intent routing rules to the lark-calendar skill documentation. It directs past-meeting queries to the lark-vc skill while reserving future-time and calendar/schedule requests for lark-calendar, clarifying the skill's responsibility boundaries. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
skills/lark-calendar/SKILL.md (1)
17-19: Consider aligning terminology with lark-vc for consistency.The routing logic is sound and correctly delegates past meeting queries to lark-vc. However, the term "过去时间的会议" (meetings at past times) could be more precise.
The lark-vc documentation consistently uses "已结束的会议" or "历史会议记录" (ended meetings / historical meeting records), which more accurately describes what vc +search retrieves—meetings that have actually concluded, not just meetings scheduled for past times.
Consider refining line 18 to better align with lark-vc's terminology and include additional examples from lark-vc's documented trigger expressions:
-**查询过去时间的会议**:如果用户明确查询过去时间的会议(如"昨天的会议"、"上周的会议"),**优先使用 [`../lark-vc/SKILL.md`](../lark-vc/SKILL.md) 搜索会议记录**。因为会议数据不仅包含从日程发起的视频会议,还包含即时会议,仅查询日程数据会导致结果不全。 +**查询已结束的会议**:如果用户明确查询已结束或历史会议(如"昨天的会议"、"上周的会议"、"今天开过的会"、"最近参加过哪些会"),**优先使用 [`../lark-vc/SKILL.md`](../lark-vc/SKILL.md) 搜索会议记录**。因为会议数据不仅包含从日程发起的视频会议,还包含即时会议,仅查询日程数据会导致结果不全。This change improves clarity by:
- Using "已结束的会议" to match lark-vc's terminology
- Adding examples that align with lark-vc's documented trigger expressions ("今天开过的会"、"最近参加过哪些会")
Based on learnings from lark-vc/SKILL.md routing rules: "如果用户在问'开过的会''今天开了哪些会''最近参加过什么会''已结束的会议''历史会议记录',优先使用 vc +search。"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/lark-calendar/SKILL.md` around lines 17 - 19, Update the routing wording in SKILL.md: replace the phrase "过去时间的会议" with the lark-vc aligned terms "已结束的会议" or "历史会议记录" and add example trigger expressions such as "今天开过的会" and "最近参加过哪些会" so the line that currently directs past-meeting queries to ../lark-vc/SKILL.md matches lark-vc terminology and examples; keep the existing rule that past/ended meeting queries route to lark-vc while calendar/scheduled/future queries remain in lark-calendar.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@skills/lark-calendar/SKILL.md`:
- Around line 17-19: Update the routing wording in SKILL.md: replace the phrase
"过去时间的会议" with the lark-vc aligned terms "已结束的会议" or "历史会议记录" and add example
trigger expressions such as "今天开过的会" and "最近参加过哪些会" so the line that currently
directs past-meeting queries to ../lark-vc/SKILL.md matches lark-vc terminology
and examples; keep the existing rule that past/ended meeting queries route to
lark-vc while calendar/scheduled/future queries remain in lark-calendar.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a0729495-0cce-4549-b325-15ead12a6fb9
📒 Files selected for processing (1)
skills/lark-calendar/SKILL.md
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@501f859c9275fab0037468f2fdcb254025ba411a🧩 Skill updatenpx skills add larksuite/cli#docs/lark-calendar-past-meeting-routing -y -g |
Summary
Clarify the routing rule between
lark-calendarandlark-vcfor meeting-related requests.This makes past meeting queries go to meeting records, while keeping calendar/event and future meeting queries in
lark-calendar.Changes
skills/lark-calendar/SKILL.mdfor past meeting querieslark-vcbecause calendar-only data can be incompletelark-calendarTest Plan
make unit-test)Related Issues
Summary by CodeRabbit