Skip to content

feat(wiki): improve wiki skill docs and add wiki domain template#512

Merged
fangshuyu-768 merged 1 commit intomainfrom
feat/wiki-skill-improvements
Apr 17, 2026
Merged

feat(wiki): improve wiki skill docs and add wiki domain template#512
fangshuyu-768 merged 1 commit intomainfrom
feat/wiki-skill-improvements

Conversation

@liujinkun2025
Copy link
Copy Markdown
Collaborator

@liujinkun2025 liujinkun2025 commented Apr 16, 2026

Summary

  • Add spaces.create method to wiki API resources and permission table
  • Reorder "target semantic constraints" section for better reading flow
  • Fix list indentation and punctuation formatting in SKILL.md

Test plan

  • Verify lark-cli wiki spaces create works with --as user
  • Confirm skill-template/domains/wiki.md is correctly picked up by skill loader

Summary by CodeRabbit

  • Documentation
    • Added comprehensive Wiki member-management operational rules with clear decision flows and sequential procedures
    • Clarified target semantics (personal library vs Drive) and guidance for correct ID resolution and action branching
    • Added a new API resource create method and mapped permission for creating spaces
    • Improved formatting and reorganized related sections for clarity

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026

📝 Walkthrough

Walkthrough

Adds a new Wiki domain document specifying CLI operational rules and hard constraints for member management and target semantics, and updates the lark-wiki SKILL docs to add spaces.create, a permission mapping, reorder/relocate target-semantics content, and minor formatting changes. No code changes.

Changes

Cohort / File(s) Summary
New Wiki Domain Documentation
skill-template/domains/wiki.md
New operational rules: disallow department ID use with --as bot/tenant tokens; forbid try-create-then-infer credential switching; quick-decision CLI flow for token vs creation requests; ordered member-add flow (user/group/department resolution) and target-semantics (personal library vs Drive).
Wiki Skill Documentation Updates
skills/lark-wiki/SKILL.md
Moved/reinserted "目标语义约束" near "成员添加流程"; added spaces.create API method and permission mapping spaces.createwiki:space:write_only; minor table/formatting adjustments.

Sequence Diagram(s)

(omitted — changes are documentation updates describing CLI flows; no new runtime control-flow code introduced)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • fangshuyu-768
  • kongenpei

Poem

🐰 I hopped through docs to make things clear,
Rules for members, roles far and near.
Bots at the gate, departments stay out,
Personal spaces sorted — no doubt!
Huzzah — tidy guides and fewer shouts.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat(wiki): improve wiki skill docs and add wiki domain template' clearly summarizes the main changes: documentation improvements and the addition of a new domain template file.
Description check ✅ Passed The PR description covers the required sections: Summary (with concise bullet points), Test plan (with checkboxes), and adequately describes the changes made in the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/wiki-skill-improvements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added domain/ccm PR touches the ccm domain size/M Single-domain feat or fix with limited business impact labels Apr 16, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
skills/lark-wiki/SKILL.md (1)

15-44: Note: Content duplication with template file.

The sections "成员管理硬限制", "快速决策", "成员添加流程", and "目标语义约束" (lines 15-44) are duplicated in the new skill-template/domains/wiki.md file. If this duplication is intentional (e.g., the template is meant to be referenced or included), consider adding a comment or reference to clarify the relationship. If not intentional, consider consolidating to a single source to reduce maintenance burden.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@skills/lark-wiki/SKILL.md` around lines 15 - 44, The four sections
("成员管理硬限制", "快速决策", "成员添加流程", "目标语义约束") are duplicated between
skills/lark-wiki/SKILL.md and skill-template/domains/wiki.md; fix by
consolidating to one canonical source and clarifying intent: either remove the
duplicated blocks from SKILL.md and add a short reference comment pointing to
the template (e.g., "See template/domains/wiki.md for member-management rules"),
or keep SKILL.md as the canonical copy and remove them from the template, and in
either case update the remaining file to include a brief comment explaining that
this content is shared and must be edited in the canonical location so
reviewers/maintainers know the relationship.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@skills/lark-wiki/SKILL.md`:
- Line 86: Update the permission scope for the spaces.create entry: replace the
incorrect scope string `wiki:space:write_only` with the correct `wiki:wiki` in
the SKILL.md permission table so that the `spaces.create` method lists
`wiki:wiki` as its required scope.

---

Nitpick comments:
In `@skills/lark-wiki/SKILL.md`:
- Around line 15-44: The four sections ("成员管理硬限制", "快速决策", "成员添加流程", "目标语义约束")
are duplicated between skills/lark-wiki/SKILL.md and
skill-template/domains/wiki.md; fix by consolidating to one canonical source and
clarifying intent: either remove the duplicated blocks from SKILL.md and add a
short reference comment pointing to the template (e.g., "See
template/domains/wiki.md for member-management rules"), or keep SKILL.md as the
canonical copy and remove them from the template, and in either case update the
remaining file to include a brief comment explaining that this content is shared
and must be edited in the canonical location so reviewers/maintainers know the
relationship.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 502e81b9-26c8-40a7-a10d-729ccb47c458

📥 Commits

Reviewing files that changed from the base of the PR and between 1608f95 and d6bbbb3.

📒 Files selected for processing (2)
  • skill-template/domains/wiki.md
  • skills/lark-wiki/SKILL.md

Comment thread skills/lark-wiki/SKILL.md
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@422e7d15a97568fdab41944f0fd603883a88e6ea

🧩 Skill update

npx skills add larksuite/cli#feat/wiki-skill-improvements -y -g

- Reorder sections, fix formatting and indentation in SKILL.md
- Add spaces.create method and its scope to API resources and permission table
- Add wiki domain template for skill-template

Change-Id: Ib03dacc02cf2b42f807615c2adedbf79694b5dc0
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@liujinkun2025 liujinkun2025 force-pushed the feat/wiki-skill-improvements branch from d6bbbb3 to 422e7d1 Compare April 17, 2026 06:20
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (1)
skills/lark-wiki/SKILL.md (1)

86-86: ⚠️ Potential issue | 🟠 Major

Fix spaces.create scope mapping on Line 86.

wiki:space:write_only appears incorrect for spaces.create; this should be updated to the documented scope for that endpoint (commonly wiki:wiki in official docs).

🔧 Proposed fix
-| `spaces.create` | `wiki:space:write_only` |
+| `spaces.create` | `wiki:wiki` |
Check the official Lark/Feishu Open Platform docs for:
1) wiki-v2 space create endpoint required scope
2) exact scope string for `spaces.create` in current docs
Prefer official pages:
- open.larksuite.com/document/server-docs/docs/wiki-v2/space/create
- open.feishu.cn/document/server-docs/docs/wiki-v2/space/create
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@skills/lark-wiki/SKILL.md` at line 86, Update the scope mapping for the
spaces.create entry: replace the incorrect `wiki:space:write_only` scope with
the documented scope `wiki:wiki` for the `spaces.create` endpoint so the
permission string matches the official Lark/Feishu Open Platform docs (verify
against the wiki-v2 space create documentation if needed).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@skills/lark-wiki/SKILL.md`:
- Line 86: Update the scope mapping for the spaces.create entry: replace the
incorrect `wiki:space:write_only` scope with the documented scope `wiki:wiki`
for the `spaces.create` endpoint so the permission string matches the official
Lark/Feishu Open Platform docs (verify against the wiki-v2 space create
documentation if needed).

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4df359c6-3cdb-4d57-bb45-eb42c94e620c

📥 Commits

Reviewing files that changed from the base of the PR and between d6bbbb3 and 422e7d1.

📒 Files selected for processing (2)
  • skill-template/domains/wiki.md
  • skills/lark-wiki/SKILL.md

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@e10bf8e). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #512   +/-   ##
=======================================
  Coverage        ?   59.05%           
=======================================
  Files           ?      384           
  Lines           ?    32637           
  Branches        ?        0           
=======================================
  Hits            ?    19275           
  Misses          ?    11554           
  Partials        ?     1808           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fangshuyu-768 fangshuyu-768 merged commit ba19bd9 into main Apr 17, 2026
22 checks passed
@fangshuyu-768 fangshuyu-768 deleted the feat/wiki-skill-improvements branch April 17, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/ccm PR touches the ccm domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants