feat(wiki): improve wiki skill docs and add wiki domain template#512
feat(wiki): improve wiki skill docs and add wiki domain template#512fangshuyu-768 merged 1 commit intomainfrom
Conversation
📝 WalkthroughWalkthroughAdds a new Wiki domain document specifying CLI operational rules and hard constraints for member management and target semantics, and updates the lark-wiki SKILL docs to add Changes
Sequence Diagram(s)(omitted — changes are documentation updates describing CLI flows; no new runtime control-flow code introduced) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
skills/lark-wiki/SKILL.md (1)
15-44: Note: Content duplication with template file.The sections "成员管理硬限制", "快速决策", "成员添加流程", and "目标语义约束" (lines 15-44) are duplicated in the new
skill-template/domains/wiki.mdfile. If this duplication is intentional (e.g., the template is meant to be referenced or included), consider adding a comment or reference to clarify the relationship. If not intentional, consider consolidating to a single source to reduce maintenance burden.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/lark-wiki/SKILL.md` around lines 15 - 44, The four sections ("成员管理硬限制", "快速决策", "成员添加流程", "目标语义约束") are duplicated between skills/lark-wiki/SKILL.md and skill-template/domains/wiki.md; fix by consolidating to one canonical source and clarifying intent: either remove the duplicated blocks from SKILL.md and add a short reference comment pointing to the template (e.g., "See template/domains/wiki.md for member-management rules"), or keep SKILL.md as the canonical copy and remove them from the template, and in either case update the remaining file to include a brief comment explaining that this content is shared and must be edited in the canonical location so reviewers/maintainers know the relationship.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skills/lark-wiki/SKILL.md`:
- Line 86: Update the permission scope for the spaces.create entry: replace the
incorrect scope string `wiki:space:write_only` with the correct `wiki:wiki` in
the SKILL.md permission table so that the `spaces.create` method lists
`wiki:wiki` as its required scope.
---
Nitpick comments:
In `@skills/lark-wiki/SKILL.md`:
- Around line 15-44: The four sections ("成员管理硬限制", "快速决策", "成员添加流程", "目标语义约束")
are duplicated between skills/lark-wiki/SKILL.md and
skill-template/domains/wiki.md; fix by consolidating to one canonical source and
clarifying intent: either remove the duplicated blocks from SKILL.md and add a
short reference comment pointing to the template (e.g., "See
template/domains/wiki.md for member-management rules"), or keep SKILL.md as the
canonical copy and remove them from the template, and in either case update the
remaining file to include a brief comment explaining that this content is shared
and must be edited in the canonical location so reviewers/maintainers know the
relationship.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 502e81b9-26c8-40a7-a10d-729ccb47c458
📒 Files selected for processing (2)
skill-template/domains/wiki.mdskills/lark-wiki/SKILL.md
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@422e7d15a97568fdab41944f0fd603883a88e6ea🧩 Skill updatenpx skills add larksuite/cli#feat/wiki-skill-improvements -y -g |
- Reorder sections, fix formatting and indentation in SKILL.md - Add spaces.create method and its scope to API resources and permission table - Add wiki domain template for skill-template Change-Id: Ib03dacc02cf2b42f807615c2adedbf79694b5dc0 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
d6bbbb3 to
422e7d1
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
skills/lark-wiki/SKILL.md (1)
86-86:⚠️ Potential issue | 🟠 MajorFix
spaces.createscope mapping on Line 86.
wiki:space:write_onlyappears incorrect forspaces.create; this should be updated to the documented scope for that endpoint (commonlywiki:wikiin official docs).🔧 Proposed fix
-| `spaces.create` | `wiki:space:write_only` | +| `spaces.create` | `wiki:wiki` |Check the official Lark/Feishu Open Platform docs for: 1) wiki-v2 space create endpoint required scope 2) exact scope string for `spaces.create` in current docs Prefer official pages: - open.larksuite.com/document/server-docs/docs/wiki-v2/space/create - open.feishu.cn/document/server-docs/docs/wiki-v2/space/create🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/lark-wiki/SKILL.md` at line 86, Update the scope mapping for the spaces.create entry: replace the incorrect `wiki:space:write_only` scope with the documented scope `wiki:wiki` for the `spaces.create` endpoint so the permission string matches the official Lark/Feishu Open Platform docs (verify against the wiki-v2 space create documentation if needed).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@skills/lark-wiki/SKILL.md`:
- Line 86: Update the scope mapping for the spaces.create entry: replace the
incorrect `wiki:space:write_only` scope with the documented scope `wiki:wiki`
for the `spaces.create` endpoint so the permission string matches the official
Lark/Feishu Open Platform docs (verify against the wiki-v2 space create
documentation if needed).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4df359c6-3cdb-4d57-bb45-eb42c94e620c
📒 Files selected for processing (2)
skill-template/domains/wiki.mdskills/lark-wiki/SKILL.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
=======================================
Coverage ? 59.05%
=======================================
Files ? 384
Lines ? 32637
Branches ? 0
=======================================
Hits ? 19275
Misses ? 11554
Partials ? 1808 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
spaces.createmethod to wiki API resources and permission tableTest plan
lark-cli wiki spaces createworks with--as userSummary by CodeRabbit