Merged
Conversation
|
|
📝 WalkthroughWalkthroughUpdated role-config documentation: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
domain/base
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skills/lark-base/references/role-config.md`:
- Line 478: The docs contradict on the default for the allow_edit field; update
the fields table entry for allow_edit to be conditional to match the
permission-check text: state that when perm == "edit" allow_edit defaults to
true (but still requires the visibility field when true), otherwise allow_edit
defaults to false unless explicitly set; ensure the wording references the same
terms used elsewhere ("allow_edit", "perm", "visibility") so implementers
construct JSON consistently with the permission flow described.
- Line 418: The table row claiming `record_operations` 中的 `delete` is "包含（perm =
edit 时）" is misplaced under the "默认关闭项" subsection; either move that row to the
"记录操作默认策略" subsection (or an appropriate "默认开启项" area) or rename the subsection
from "默认关闭项" to reflect that it includes default-enabled operations; update the
table placement or subsection title so `record_operations`, `delete` (`perm =
edit`) appears under a section that accurately indicates it is a
default-included operation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5caf6731-bdd1-41ba-8c4e-67232f70aa16
📒 Files selected for processing (1)
skills/lark-base/references/role-config.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #530 +/- ##
=======================================
Coverage 60.19% 60.19%
=======================================
Files 390 390
Lines 33433 33433
=======================================
Hits 20125 20125
Misses 11426 11426
Partials 1882 1882 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@dc45628b244a99532ae6f2a8ca4e890a750a9f08🧩 Skill updatenpx skills add larksuite/cli#fix-base-perm-view -y -g |
There was a problem hiding this comment.
♻️ Duplicate comments (1)
skills/lark-base/references/role-config.md (1)
486-486:⚠️ Potential issue | 🟡 MinorLine 486 建议显式写出
perm = read_only时allow_edit = false，避免跨段阅读歧义。虽然前文已说明，但此处“仅用户明确限制才设为 false”容易被单段读取为唯一条件，建议与 Line 196/Line 216 对齐写全。
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/lark-base/references/role-config.md` at line 486, Clarify the rule for allow_edit by explicitly stating that when perm = read_only, allow_edit must be set to false; update the sentence around `allow_edit` (and the example referencing "视图权限 情况 A") to mirror the explicit wording used at Line 196/216 so readers see both the default-for-edit case and the explicit read_only case, and note that when allow_edit is true the `visibility` field is still required.
🧹 Nitpick comments (1)
skills/lark-base/references/role-config.md (1)
447-447: Line 447 的“仅适用于”表述过于绝对，建议补齐read_only/no_perm例外。当前句子与 Line 452 的约束组合后存在语义冲突：
perm = read_only（以及no_perm）时delete也不会包含，不是仅“用户明确限制”这一种情况。✏️ 建议文案
-- 用户未提及时，表权限为 `edit` 时默认同时包含 `add` 和 `delete`，默认不包含 `delete` 的情况仅适用于用户明确限制操作的场景 +- 用户未提及时，表权限为 `edit` 时默认同时包含 `add` 和 `delete`；当用户明确限制操作，或表权限非 `edit`（如 `read_only` / `no_perm`）时，不包含 `delete`🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/lark-base/references/role-config.md` at line 447, Update the sentence "用户未提及时，表权限为 `edit` 时默认同时包含 `add` 和 `delete`，默认不包含 `delete` 的情况仅适用于用户明确限制操作的场景" to clarify exceptions for `read_only` and `no_perm` so it doesn't conflict with the constraint described later (the rule at Line 452); explicitly state that when perm is `read_only` or `no_perm` `delete` is not included regardless of user omission, and keep the `edit` default behavior for cases that are not those exceptions.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@skills/lark-base/references/role-config.md`:
- Line 486: Clarify the rule for allow_edit by explicitly stating that when perm
= read_only, allow_edit must be set to false; update the sentence around
`allow_edit` (and the example referencing "视图权限 情况 A") to mirror the explicit
wording used at Line 196/216 so readers see both the default-for-edit case and
the explicit read_only case, and note that when allow_edit is true the
`visibility` field is still required.
---
Nitpick comments:
In `@skills/lark-base/references/role-config.md`:
- Line 447: Update the sentence "用户未提及时，表权限为 `edit` 时默认同时包含 `add` 和
`delete`，默认不包含 `delete` 的情况仅适用于用户明确限制操作的场景" to clarify exceptions for
`read_only` and `no_perm` so it doesn't conflict with the constraint described
later (the rule at Line 452); explicitly state that when perm is `read_only` or
`no_perm` `delete` is not included regardless of user omission, and keep the
`edit` default behavior for cases that are not those exceptions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ca3068b8-a99a-4103-81b3-a5d167f50e21
📒 Files selected for processing (1)
skills/lark-base/references/role-config.md
fix: address coderabbit review comments on role-config docs - Update `allow_edit` field description to reflect conditional default: `true` when table perm is `edit`, `false` for `read_only` or explicit restriction - Move `record_operations.delete` out of "默认关闭项" into new "默认开启项（条件性）" section to accurately reflect it is default-included when `perm = edit` - Add `view_rule.allow_edit` to "默认开启项（条件性）" section with same logic Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
zhengquanbin
force-pushed
the
fix-base-perm-view
branch
from
f96bbea to
dc45628
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
skills/lark-base/references/role-config.md (1)
419-427: 新增章节未加入目录，文档导航会断层。已新增“默认开启项（条件性）”，但目录区（Line 20-Line 26）没有对应条目，建议补一行目录锚点。
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/lark-base/references/role-config.md` around lines 419 - 427, The new section titled "默认开启项（条件性）" was added but not referenced in the document's table of contents, causing a navigation gap; add a TOC entry/anchor in the existing目录区 that links to the header "默认开启项（条件性）" (matching the exact header text) so readers can navigate to this section, ensuring the anchor format matches the rest of the TOC entries.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skills/lark-base/references/role-config.md`:
- Line 486: Add an explicit rule that when perm == read_only the allow_edit
field must be false: update the logic/validation around allow_edit (used when
perm == edit vs perm == read_only) so that for perm = edit allow_edit defaults
to true and still requires visibility, and for perm = read_only ensure
allow_edit is explicitly set/validated to false (reference the allow_edit, perm,
read_only, edit and visibility fields/conditions and the "视图权限 情况 A" semantics
when making the change).
- Around line 226-230: The example in the view_rule block incorrectly hardcodes
"allow_edit": true which conflicts with the documented A/B decision rule; update
the example/template so that view_rule.allow_edit is determined by the A/B rule
(e.g., show two variants or a placeholder) rather than a fixed true value, and
clarify in the surrounding text that allow_edit follows the A/B logic
(respecting perm = read_only and user-imposed restrictions); reference the
view_rule, allow_edit and visibility keys when making this change so the example
matches the described behavior.
---
Nitpick comments:
In `@skills/lark-base/references/role-config.md`:
- Around line 419-427: The new section titled "默认开启项（条件性）" was added but not
referenced in the document's table of contents, causing a navigation gap; add a
TOC entry/anchor in the existing目录区 that links to the header "默认开启项（条件性）"
(matching the exact header text) so readers can navigate to this section,
ensuring the anchor format matches the rest of the TOC entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 46e63820-5574-42d2-8600-974531b6d6f4
📒 Files selected for processing (1)
skills/lark-base/references/role-config.md
jiaxiang7
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Summary by CodeRabbit