feat(whiteboard): pin whiteboard-cli to v0.2.10 in lark-whiteboard skill#649
Conversation
📝 WalkthroughWalkthroughPins Changes
Sequence Diagram(s)sequenceDiagram
participant Author
participant Local as Local Machine (curl)
participant DocsCLI as "docs +media-upload"
participant WhiteboardSvc as Whiteboard Service
participant Renderer as Whiteboard Renderer
Author->>Local: prepare image URLs/list
Local->>Local: download images (curl) & validate real images / file-size
Local->>DocsCLI: upload each image --parent-type whiteboard --parent-node <board>
DocsCLI->>WhiteboardSvc: store media, return media_token
Author->>Author: assemble DSL with `image.src: <media_token>`
Author->>WhiteboardSvc: update board with DSL (`whiteboard +update`)
WhiteboardSvc->>Renderer: render board to PNG/preview
Renderer->>Author: return rendered preview for post-render inspection
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
==========================================
+ Coverage 62.49% 62.67% +0.17%
==========================================
Files 432 434 +2
Lines 37757 38072 +315
==========================================
+ Hits 23598 23862 +264
- Misses 12033 12076 +43
- Partials 2126 2134 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@afceee3bb5703dfc7c09fd649b2650ce46e8109b🧩 Skill updatenpx skills add larksuite/cli#feat/whiteboard-skill-cli-v0.2.10 -y -g |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skills/lark-whiteboard/references/image.md`:
- Line 7: Replace the inconsistent phrase "medias token" with the standardized
term "media token" everywhere in this whiteboard DSL doc (including places
referring to image node usage like `type: 'image'` and any mentions later in the
file), ensuring headings, inline text, and examples all use "media token"
consistently and update any surrounding phrasing for grammatical correctness if
needed.
In `@skills/lark-whiteboard/references/layout.md`:
- Line 339: Replace the caret-range version specifier for the Larksuite
whiteboard CLI with an exact pinned version: change occurrences of "@^0.2.10" to
"@0.2.10" (for example in the CLI invocation string "npx -y
`@larksuite/whiteboard-cli`@^0.2.10 -i skeleton.json -o step1.png -l
coords.json"); search for all other instances of the pattern "@^0.2.10" across
routes/, scenes/, references/, and SKILL.md and update them to use the exact
"@0.2.10" form so every reference is consistently pinned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 50f18bd8-007a-456e-9c4a-457bafae076f
📒 Files selected for processing (15)
skills/lark-whiteboard/SKILL.mdskills/lark-whiteboard/references/content.mdskills/lark-whiteboard/references/image.mdskills/lark-whiteboard/references/lark-whiteboard-update.mdskills/lark-whiteboard/references/layout.mdskills/lark-whiteboard/references/schema.mdskills/lark-whiteboard/routes/dsl.mdskills/lark-whiteboard/routes/mermaid.mdskills/lark-whiteboard/routes/svg.mdskills/lark-whiteboard/scenes/bar-chart.mdskills/lark-whiteboard/scenes/fishbone.mdskills/lark-whiteboard/scenes/flywheel.mdskills/lark-whiteboard/scenes/line-chart.mdskills/lark-whiteboard/scenes/photo-showcase.mdskills/lark-whiteboard/scenes/treemap.md
💤 Files with no reviewable changes (1)
- skills/lark-whiteboard/references/content.md
fa80d40 to
5bdbd4a
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skills/lark-whiteboard/references/image.md`:
- Line 47: The phrase "本地渲染 PNG 后(Step 3)" is ambiguous; update the sentence to
explicitly reference the local-rendering substep within Step 0 (e.g., replace
"Step 3" with "见 Step 0 的“本地渲染”子步骤" or "见 Step 0 子步骤 2:本地渲染") so readers know
which substep to check; locate the exact string "本地渲染 PNG 后(Step 3)" in
skills/lark-whiteboard/references/image.md and replace it with the clarified
substep reference.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5b866466-d9f0-446e-82ff-1380c76795df
📒 Files selected for processing (15)
skills/lark-whiteboard/SKILL.mdskills/lark-whiteboard/references/content.mdskills/lark-whiteboard/references/image.mdskills/lark-whiteboard/references/lark-whiteboard-update.mdskills/lark-whiteboard/references/layout.mdskills/lark-whiteboard/references/schema.mdskills/lark-whiteboard/routes/dsl.mdskills/lark-whiteboard/routes/mermaid.mdskills/lark-whiteboard/routes/svg.mdskills/lark-whiteboard/scenes/bar-chart.mdskills/lark-whiteboard/scenes/fishbone.mdskills/lark-whiteboard/scenes/flywheel.mdskills/lark-whiteboard/scenes/line-chart.mdskills/lark-whiteboard/scenes/photo-showcase.mdskills/lark-whiteboard/scenes/treemap.md
💤 Files with no reviewable changes (1)
- skills/lark-whiteboard/references/content.md
✅ Files skipped from review due to trivial changes (9)
- skills/lark-whiteboard/scenes/line-chart.md
- skills/lark-whiteboard/scenes/flywheel.md
- skills/lark-whiteboard/scenes/bar-chart.md
- skills/lark-whiteboard/scenes/treemap.md
- skills/lark-whiteboard/routes/svg.md
- skills/lark-whiteboard/routes/mermaid.md
- skills/lark-whiteboard/routes/dsl.md
- skills/lark-whiteboard/references/lark-whiteboard-update.md
- skills/lark-whiteboard/scenes/fishbone.md
🚧 Files skipped from review as they are similar to previous changes (3)
- skills/lark-whiteboard/references/layout.md
- skills/lark-whiteboard/SKILL.md
- skills/lark-whiteboard/references/schema.md
5bdbd4a to
73515f0
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skills/lark-whiteboard/references/image.md`:
- Around line 42-43: The current guidance uses "ls -l *.jpg" which is unreliable
for duplicate detection; replace or augment that step with deterministic hash
checks (e.g., compute SHA256 or MD5 for each file using shasum/sha256sum and
compare hashes) so identical files produce identical hashes and true duplicates
are detectable; update the image.md instruction to show generating hashes for
all images, sorting/grouping by hash, and then flagging or removing files with
identical hashes rather than relying on file size alone.
In `@skills/lark-whiteboard/SKILL.md`:
- Line 16: Replace the caret version specifier in the whiteboard CLI install
commands with an exact pin: change occurrences of the string "npx -y
`@larksuite/whiteboard-cli`@^0.2.10 -v" to "npx -y
`@larksuite/whiteboard-cli`@0.2.10 -v" (apply to every occurrence referenced in
SKILL.md, e.g., the command on lines showing the npx invocation).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 56985f0e-d875-4d31-b9f6-22649d6b1f43
📒 Files selected for processing (15)
skills/lark-whiteboard/SKILL.mdskills/lark-whiteboard/references/content.mdskills/lark-whiteboard/references/image.mdskills/lark-whiteboard/references/lark-whiteboard-update.mdskills/lark-whiteboard/references/layout.mdskills/lark-whiteboard/references/schema.mdskills/lark-whiteboard/routes/dsl.mdskills/lark-whiteboard/routes/mermaid.mdskills/lark-whiteboard/routes/svg.mdskills/lark-whiteboard/scenes/bar-chart.mdskills/lark-whiteboard/scenes/fishbone.mdskills/lark-whiteboard/scenes/flywheel.mdskills/lark-whiteboard/scenes/line-chart.mdskills/lark-whiteboard/scenes/photo-showcase.mdskills/lark-whiteboard/scenes/treemap.md
💤 Files with no reviewable changes (1)
- skills/lark-whiteboard/references/content.md
✅ Files skipped from review due to trivial changes (7)
- skills/lark-whiteboard/scenes/bar-chart.md
- skills/lark-whiteboard/scenes/treemap.md
- skills/lark-whiteboard/routes/mermaid.md
- skills/lark-whiteboard/routes/dsl.md
- skills/lark-whiteboard/references/lark-whiteboard-update.md
- skills/lark-whiteboard/scenes/line-chart.md
- skills/lark-whiteboard/scenes/flywheel.md
🚧 Files skipped from review as they are similar to previous changes (3)
- skills/lark-whiteboard/scenes/fishbone.md
- skills/lark-whiteboard/references/layout.md
- skills/lark-whiteboard/routes/svg.md
73515f0 to
afceee3
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
skills/lark-whiteboard/scenes/photo-showcase.md (1)
13-13:⚠️ Potential issue | 🟠 MajorFile-size comparison is insufficient for duplicate detection.
Using
ls -lto compare file sizes can miss duplicates (different images can have the same size) and incorrectly flag different images. This same concern was already raised in the past review comments forimage.mdlines 42-43, which recommended using hash-based verification (e.g.,sha256sum) instead.🔧 Recommended fix using hash verification
-- 下载后用 `ls -l` 比较文件大小确保每张图不重复 +- 下载后用 `sha256sum *.jpg` 比较哈希值确保每张图不重复🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/lark-whiteboard/scenes/photo-showcase.md` at line 13, Replace the unreliable file-size comparison using `ls -l` with a hash-based duplicate check: compute and compare cryptographic hashes (e.g., `sha256sum` or `shasum -a 256`) for each downloaded image and use those hashes to detect duplicates; update the instructions in the photo-showcase.md content to show the hash command and explain comparing hash values rather than file sizes so identical files are reliably detected.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@skills/lark-whiteboard/scenes/photo-showcase.md`:
- Line 13: Replace the unreliable file-size comparison using `ls -l` with a
hash-based duplicate check: compute and compare cryptographic hashes (e.g.,
`sha256sum` or `shasum -a 256`) for each downloaded image and use those hashes
to detect duplicates; update the instructions in the photo-showcase.md content
to show the hash command and explain comparing hash values rather than file
sizes so identical files are reliably detected.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 366eca5e-dac2-4b8c-a1f8-6495fedaa0f4
📒 Files selected for processing (15)
skills/lark-whiteboard/SKILL.mdskills/lark-whiteboard/references/content.mdskills/lark-whiteboard/references/image.mdskills/lark-whiteboard/references/lark-whiteboard-update.mdskills/lark-whiteboard/references/layout.mdskills/lark-whiteboard/references/schema.mdskills/lark-whiteboard/routes/dsl.mdskills/lark-whiteboard/routes/mermaid.mdskills/lark-whiteboard/routes/svg.mdskills/lark-whiteboard/scenes/bar-chart.mdskills/lark-whiteboard/scenes/fishbone.mdskills/lark-whiteboard/scenes/flywheel.mdskills/lark-whiteboard/scenes/line-chart.mdskills/lark-whiteboard/scenes/photo-showcase.mdskills/lark-whiteboard/scenes/treemap.md
💤 Files with no reviewable changes (1)
- skills/lark-whiteboard/references/content.md
✅ Files skipped from review due to trivial changes (6)
- skills/lark-whiteboard/scenes/flywheel.md
- skills/lark-whiteboard/scenes/treemap.md
- skills/lark-whiteboard/routes/svg.md
- skills/lark-whiteboard/routes/mermaid.md
- skills/lark-whiteboard/references/lark-whiteboard-update.md
- skills/lark-whiteboard/scenes/bar-chart.md
🚧 Files skipped from review as they are similar to previous changes (4)
- skills/lark-whiteboard/scenes/line-chart.md
- skills/lark-whiteboard/scenes/fishbone.md
- skills/lark-whiteboard/references/layout.md
- skills/lark-whiteboard/SKILL.md
Summary
Changes
feat(whiteboard): pin whiteboard-cli to v0.2.10 in lark-whiteboard skill
Related Issues
Summary by CodeRabbit
Chores
New Features
Documentation