Skip to content

feat(whiteboard): pin whiteboard-cli to v0.2.10 in lark-whiteboard skill#649

Merged
zkh-bytedance merged 1 commit intomainfrom
feat/whiteboard-skill-cli-v0.2.10
Apr 24, 2026
Merged

feat(whiteboard): pin whiteboard-cli to v0.2.10 in lark-whiteboard skill#649
zkh-bytedance merged 1 commit intomainfrom
feat/whiteboard-skill-cli-v0.2.10

Conversation

@zkh-bytedance
Copy link
Copy Markdown
Collaborator

@zkh-bytedance zkh-bytedance commented Apr 23, 2026

Summary

Changes

feat(whiteboard): pin whiteboard-cli to v0.2.10 in lark-whiteboard skill

Related Issues

  • None

Summary by CodeRabbit

  • Chores

    • Updated whiteboard CLI version references across documentation.
  • New Features

    • Image nodes now require whiteboard-scoped media tokens and uploads to the target board.
  • Documentation

    • Rewrote Image Preparation workflow: download, validate, upload, verify; forbids placeholder services.
    • Removed keyword-triggered image insertion and legacy image+text card guidance; expanded post-render validation and deduplication checks.

@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label Apr 23, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

📝 Walkthrough

Walkthrough

Pins @larksuite/whiteboard-cli from ^0.2.9 to ^0.2.10 across docs; replaces Drive file_token image workflow with whiteboard-scoped media tokens via docs +media-upload; removes keyword-based image-request detection and a specific image-text card layout; switches deduplication/validation to file-size checks.

Changes

Cohort / File(s) Summary
CLI Version Updates
skills/lark-whiteboard/SKILL.md, skills/lark-whiteboard/references/lark-whiteboard-update.md, skills/lark-whiteboard/references/layout.md, skills/lark-whiteboard/routes/dsl.md, skills/lark-whiteboard/routes/mermaid.md, skills/lark-whiteboard/routes/svg.md, skills/lark-whiteboard/scenes/bar-chart.md, skills/lark-whiteboard/scenes/fishbone.md, skills/lark-whiteboard/scenes/flywheel.md, skills/lark-whiteboard/scenes/line-chart.md, skills/lark-whiteboard/scenes/treemap.md
Bump @larksuite/whiteboard-cli npx examples from ^0.2.9 to ^0.2.10.
Image Token & Upload Workflow
skills/lark-whiteboard/references/image.md, skills/lark-whiteboard/references/schema.md, skills/lark-whiteboard/scenes/photo-showcase.md
Replace Drive file_token flow with per-image whiteboard media_token via docs +media-upload --parent-type whiteboard --parent-node <board>; require image.src be media_token, mandate curl downloads and image validation, update upload command and error cases, and change deduplication to file-size checks.
Content & Routing Removals
skills/lark-whiteboard/references/content.md, skills/lark-whiteboard/references/layout.md, skills/lark-whiteboard/routes/dsl.md
Remove keyword-based image-request detection and delete the “图文卡片” layout section and related routing/index references.
Photo-Showcase Checklist
skills/lark-whiteboard/scenes/photo-showcase.md
Expand checklist: require whiteboard-scoped media tokens, add post-render theme relevance validation, forbid random placeholder services, and switch uniqueness check to file-size comparison.

Sequence Diagram(s)

sequenceDiagram
    participant Author
    participant Local as Local Machine (curl)
    participant DocsCLI as "docs +media-upload"
    participant WhiteboardSvc as Whiteboard Service
    participant Renderer as Whiteboard Renderer

    Author->>Local: prepare image URLs/list
    Local->>Local: download images (curl) & validate real images / file-size
    Local->>DocsCLI: upload each image --parent-type whiteboard --parent-node <board>
    DocsCLI->>WhiteboardSvc: store media, return media_token
    Author->>Author: assemble DSL with `image.src: <media_token>`
    Author->>WhiteboardSvc: update board with DSL (`whiteboard +update`)
    WhiteboardSvc->>Renderer: render board to PNG/preview
    Renderer->>Author: return rendered preview for post-render inspection
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

domain/ccm

Suggested reviewers

  • syh-cpdsss

Poem

🐰 I curl the pixels, nibble tokens bright,
Hop uploads to boards by soft moonlight,
Sizes counted, placeholders barred away,
CLI bumped, images snug where they stay. 🎨🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete, missing key sections from the template: Summary lacks motivation, Changes section is only a copy of the title, and Test Plan is entirely absent. Add a brief motivation (1-3 sentences) in Summary, list the main changes, and include a Test Plan describing how this version bump was verified.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the primary change: pinning whiteboard-cli to v0.2.10 across the lark-whiteboard skill documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/whiteboard-skill-cli-v0.2.10

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.67%. Comparing base (e42033f) to head (afceee3).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
+ Coverage   62.49%   62.67%   +0.17%     
==========================================
  Files         432      434       +2     
  Lines       37757    38072     +315     
==========================================
+ Hits        23598    23862     +264     
- Misses      12033    12076      +43     
- Partials     2126     2134       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@afceee3bb5703dfc7c09fd649b2650ce46e8109b

🧩 Skill update

npx skills add larksuite/cli#feat/whiteboard-skill-cli-v0.2.10 -y -g

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@skills/lark-whiteboard/references/image.md`:
- Line 7: Replace the inconsistent phrase "medias token" with the standardized
term "media token" everywhere in this whiteboard DSL doc (including places
referring to image node usage like `type: 'image'` and any mentions later in the
file), ensuring headings, inline text, and examples all use "media token"
consistently and update any surrounding phrasing for grammatical correctness if
needed.

In `@skills/lark-whiteboard/references/layout.md`:
- Line 339: Replace the caret-range version specifier for the Larksuite
whiteboard CLI with an exact pinned version: change occurrences of "@^0.2.10" to
"@0.2.10" (for example in the CLI invocation string "npx -y
`@larksuite/whiteboard-cli`@^0.2.10 -i skeleton.json -o step1.png -l
coords.json"); search for all other instances of the pattern "@^0.2.10" across
routes/, scenes/, references/, and SKILL.md and update them to use the exact
"@0.2.10" form so every reference is consistently pinned.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 50f18bd8-007a-456e-9c4a-457bafae076f

📥 Commits

Reviewing files that changed from the base of the PR and between e42033f and fa80d40.

📒 Files selected for processing (15)
  • skills/lark-whiteboard/SKILL.md
  • skills/lark-whiteboard/references/content.md
  • skills/lark-whiteboard/references/image.md
  • skills/lark-whiteboard/references/lark-whiteboard-update.md
  • skills/lark-whiteboard/references/layout.md
  • skills/lark-whiteboard/references/schema.md
  • skills/lark-whiteboard/routes/dsl.md
  • skills/lark-whiteboard/routes/mermaid.md
  • skills/lark-whiteboard/routes/svg.md
  • skills/lark-whiteboard/scenes/bar-chart.md
  • skills/lark-whiteboard/scenes/fishbone.md
  • skills/lark-whiteboard/scenes/flywheel.md
  • skills/lark-whiteboard/scenes/line-chart.md
  • skills/lark-whiteboard/scenes/photo-showcase.md
  • skills/lark-whiteboard/scenes/treemap.md
💤 Files with no reviewable changes (1)
  • skills/lark-whiteboard/references/content.md

Comment thread skills/lark-whiteboard/references/image.md Outdated
Comment thread skills/lark-whiteboard/references/layout.md
@zkh-bytedance zkh-bytedance force-pushed the feat/whiteboard-skill-cli-v0.2.10 branch from fa80d40 to 5bdbd4a Compare April 24, 2026 05:03
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@skills/lark-whiteboard/references/image.md`:
- Line 47: The phrase "本地渲染 PNG 后(Step 3)" is ambiguous; update the sentence to
explicitly reference the local-rendering substep within Step 0 (e.g., replace
"Step 3" with "见 Step 0 的“本地渲染”子步骤" or "见 Step 0 子步骤 2:本地渲染") so readers know
which substep to check; locate the exact string "本地渲染 PNG 后(Step 3)" in
skills/lark-whiteboard/references/image.md and replace it with the clarified
substep reference.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5b866466-d9f0-446e-82ff-1380c76795df

📥 Commits

Reviewing files that changed from the base of the PR and between fa80d40 and 5bdbd4a.

📒 Files selected for processing (15)
  • skills/lark-whiteboard/SKILL.md
  • skills/lark-whiteboard/references/content.md
  • skills/lark-whiteboard/references/image.md
  • skills/lark-whiteboard/references/lark-whiteboard-update.md
  • skills/lark-whiteboard/references/layout.md
  • skills/lark-whiteboard/references/schema.md
  • skills/lark-whiteboard/routes/dsl.md
  • skills/lark-whiteboard/routes/mermaid.md
  • skills/lark-whiteboard/routes/svg.md
  • skills/lark-whiteboard/scenes/bar-chart.md
  • skills/lark-whiteboard/scenes/fishbone.md
  • skills/lark-whiteboard/scenes/flywheel.md
  • skills/lark-whiteboard/scenes/line-chart.md
  • skills/lark-whiteboard/scenes/photo-showcase.md
  • skills/lark-whiteboard/scenes/treemap.md
💤 Files with no reviewable changes (1)
  • skills/lark-whiteboard/references/content.md
✅ Files skipped from review due to trivial changes (9)
  • skills/lark-whiteboard/scenes/line-chart.md
  • skills/lark-whiteboard/scenes/flywheel.md
  • skills/lark-whiteboard/scenes/bar-chart.md
  • skills/lark-whiteboard/scenes/treemap.md
  • skills/lark-whiteboard/routes/svg.md
  • skills/lark-whiteboard/routes/mermaid.md
  • skills/lark-whiteboard/routes/dsl.md
  • skills/lark-whiteboard/references/lark-whiteboard-update.md
  • skills/lark-whiteboard/scenes/fishbone.md
🚧 Files skipped from review as they are similar to previous changes (3)
  • skills/lark-whiteboard/references/layout.md
  • skills/lark-whiteboard/SKILL.md
  • skills/lark-whiteboard/references/schema.md

Comment thread skills/lark-whiteboard/references/image.md Outdated
@zkh-bytedance zkh-bytedance force-pushed the feat/whiteboard-skill-cli-v0.2.10 branch from 5bdbd4a to 73515f0 Compare April 24, 2026 06:38
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@skills/lark-whiteboard/references/image.md`:
- Around line 42-43: The current guidance uses "ls -l *.jpg" which is unreliable
for duplicate detection; replace or augment that step with deterministic hash
checks (e.g., compute SHA256 or MD5 for each file using shasum/sha256sum and
compare hashes) so identical files produce identical hashes and true duplicates
are detectable; update the image.md instruction to show generating hashes for
all images, sorting/grouping by hash, and then flagging or removing files with
identical hashes rather than relying on file size alone.

In `@skills/lark-whiteboard/SKILL.md`:
- Line 16: Replace the caret version specifier in the whiteboard CLI install
commands with an exact pin: change occurrences of the string "npx -y
`@larksuite/whiteboard-cli`@^0.2.10 -v" to "npx -y
`@larksuite/whiteboard-cli`@0.2.10 -v" (apply to every occurrence referenced in
SKILL.md, e.g., the command on lines showing the npx invocation).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 56985f0e-d875-4d31-b9f6-22649d6b1f43

📥 Commits

Reviewing files that changed from the base of the PR and between 5bdbd4a and 73515f0.

📒 Files selected for processing (15)
  • skills/lark-whiteboard/SKILL.md
  • skills/lark-whiteboard/references/content.md
  • skills/lark-whiteboard/references/image.md
  • skills/lark-whiteboard/references/lark-whiteboard-update.md
  • skills/lark-whiteboard/references/layout.md
  • skills/lark-whiteboard/references/schema.md
  • skills/lark-whiteboard/routes/dsl.md
  • skills/lark-whiteboard/routes/mermaid.md
  • skills/lark-whiteboard/routes/svg.md
  • skills/lark-whiteboard/scenes/bar-chart.md
  • skills/lark-whiteboard/scenes/fishbone.md
  • skills/lark-whiteboard/scenes/flywheel.md
  • skills/lark-whiteboard/scenes/line-chart.md
  • skills/lark-whiteboard/scenes/photo-showcase.md
  • skills/lark-whiteboard/scenes/treemap.md
💤 Files with no reviewable changes (1)
  • skills/lark-whiteboard/references/content.md
✅ Files skipped from review due to trivial changes (7)
  • skills/lark-whiteboard/scenes/bar-chart.md
  • skills/lark-whiteboard/scenes/treemap.md
  • skills/lark-whiteboard/routes/mermaid.md
  • skills/lark-whiteboard/routes/dsl.md
  • skills/lark-whiteboard/references/lark-whiteboard-update.md
  • skills/lark-whiteboard/scenes/line-chart.md
  • skills/lark-whiteboard/scenes/flywheel.md
🚧 Files skipped from review as they are similar to previous changes (3)
  • skills/lark-whiteboard/scenes/fishbone.md
  • skills/lark-whiteboard/references/layout.md
  • skills/lark-whiteboard/routes/svg.md

Comment thread skills/lark-whiteboard/references/image.md
Comment thread skills/lark-whiteboard/SKILL.md
@zkh-bytedance zkh-bytedance force-pushed the feat/whiteboard-skill-cli-v0.2.10 branch from 73515f0 to afceee3 Compare April 24, 2026 07:18
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (1)
skills/lark-whiteboard/scenes/photo-showcase.md (1)

13-13: ⚠️ Potential issue | 🟠 Major

File-size comparison is insufficient for duplicate detection.

Using ls -l to compare file sizes can miss duplicates (different images can have the same size) and incorrectly flag different images. This same concern was already raised in the past review comments for image.md lines 42-43, which recommended using hash-based verification (e.g., sha256sum) instead.

🔧 Recommended fix using hash verification
-- 下载后用 `ls -l` 比较文件大小确保每张图不重复
+- 下载后用 `sha256sum *.jpg` 比较哈希值确保每张图不重复
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@skills/lark-whiteboard/scenes/photo-showcase.md` at line 13, Replace the
unreliable file-size comparison using `ls -l` with a hash-based duplicate check:
compute and compare cryptographic hashes (e.g., `sha256sum` or `shasum -a 256`)
for each downloaded image and use those hashes to detect duplicates; update the
instructions in the photo-showcase.md content to show the hash command and
explain comparing hash values rather than file sizes so identical files are
reliably detected.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@skills/lark-whiteboard/scenes/photo-showcase.md`:
- Line 13: Replace the unreliable file-size comparison using `ls -l` with a
hash-based duplicate check: compute and compare cryptographic hashes (e.g.,
`sha256sum` or `shasum -a 256`) for each downloaded image and use those hashes
to detect duplicates; update the instructions in the photo-showcase.md content
to show the hash command and explain comparing hash values rather than file
sizes so identical files are reliably detected.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 366eca5e-dac2-4b8c-a1f8-6495fedaa0f4

📥 Commits

Reviewing files that changed from the base of the PR and between 73515f0 and afceee3.

📒 Files selected for processing (15)
  • skills/lark-whiteboard/SKILL.md
  • skills/lark-whiteboard/references/content.md
  • skills/lark-whiteboard/references/image.md
  • skills/lark-whiteboard/references/lark-whiteboard-update.md
  • skills/lark-whiteboard/references/layout.md
  • skills/lark-whiteboard/references/schema.md
  • skills/lark-whiteboard/routes/dsl.md
  • skills/lark-whiteboard/routes/mermaid.md
  • skills/lark-whiteboard/routes/svg.md
  • skills/lark-whiteboard/scenes/bar-chart.md
  • skills/lark-whiteboard/scenes/fishbone.md
  • skills/lark-whiteboard/scenes/flywheel.md
  • skills/lark-whiteboard/scenes/line-chart.md
  • skills/lark-whiteboard/scenes/photo-showcase.md
  • skills/lark-whiteboard/scenes/treemap.md
💤 Files with no reviewable changes (1)
  • skills/lark-whiteboard/references/content.md
✅ Files skipped from review due to trivial changes (6)
  • skills/lark-whiteboard/scenes/flywheel.md
  • skills/lark-whiteboard/scenes/treemap.md
  • skills/lark-whiteboard/routes/svg.md
  • skills/lark-whiteboard/routes/mermaid.md
  • skills/lark-whiteboard/references/lark-whiteboard-update.md
  • skills/lark-whiteboard/scenes/bar-chart.md
🚧 Files skipped from review as they are similar to previous changes (4)
  • skills/lark-whiteboard/scenes/line-chart.md
  • skills/lark-whiteboard/scenes/fishbone.md
  • skills/lark-whiteboard/references/layout.md
  • skills/lark-whiteboard/SKILL.md

@zkh-bytedance zkh-bytedance merged commit fd4c35b into main Apr 24, 2026
22 checks passed
@zkh-bytedance zkh-bytedance deleted the feat/whiteboard-skill-cli-v0.2.10 branch April 24, 2026 07:27
@liangshuo-1 liangshuo-1 mentioned this pull request Apr 24, 2026
2 tasks
@zkh-bytedance zkh-bytedance restored the feat/whiteboard-skill-cli-v0.2.10 branch April 25, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants