Fix date constructor in year padding test#29
Merged
larsdecker merged 2 commits intocodex/update-date-formatting-to-yyyymmddfrom Dec 27, 2025
Merged
Fix date constructor in year padding test#29larsdecker merged 2 commits intocodex/update-date-formatting-to-yyyymmddfrom
larsdecker merged 2 commits intocodex/update-date-formatting-to-yyyymmddfrom
Conversation
Co-authored-by: larsdecker <1968186+larsdecker@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix FinTS date formatting to use four-digit year
Fix date constructor in year padding test
Dec 27, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes a failing test in the date formatting module. The original test intended to verify that Format.date() correctly pads years below 1000 to four digits, but it was inadvertently testing year 1912 instead of year 12 due to incorrect use of the Date.UTC() constructor.
Key Changes:
- Fixed the date constructor in the year padding test to use ISO string format instead of
Date.UTC(), ensuring the test validates year 12 as intended - Updated yarn.lock with various dependency changes (appears unrelated to the test fix)
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/fints/src/tests/test-format.ts | Corrected date constructor to properly create a date in year 12 using ISO string format |
| yarn.lock | Contains multiple dependency changes including replacement of @types/winston with @types/yamljs and version string consolidations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test for year padding in
test-format.tswas failing becausenew Date(Date.UTC(12, 5, 7, 12, 0, 0))creates a date in year 1912, not year 12.Changes
new Date("0012-06-07T12:00:00Z")Format.date()correctly pads years below 1000 to four digitsThe test now correctly validates the yyyyMMdd format requirement for edge cases.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.