ZEND_ACC_ALLOW_STATIC -> ZEND_ACC_STATIC for static method#47
Open
cdosoftei wants to merge 2 commits intolaruence:masterfrom
Open
ZEND_ACC_ALLOW_STATIC -> ZEND_ACC_STATIC for static method#47cdosoftei wants to merge 2 commits intolaruence:masterfrom
cdosoftei wants to merge 2 commits intolaruence:masterfrom
Conversation
Author
|
PHP8 also requires all function/methods to explicitly declare the argument information, structure, currently it throws some initialization warnings: The second commit of this PR addresses this issue. |
Author
|
Hi @laruence 👋 just checking whether you had the chance to review this pull request, thanks! |
|
Hi, With these modifications, I succeed in building and loading the extension. Is there any plan to merge this PR ? Best regards, |
ldalek
pushed a commit
to ldalek/buildroot
that referenced
this pull request
Dec 17, 2021
The php-lua package provides a PHP extension that embeds the lua interpreter and offers an OO-API to lua variables and functions. https://pecl.php.net/package/lua Based on initial work from Nicolas Carrier <nicolas.carrier@orolia.com> Two patches are present and were retrieved from the following upstream pull request in order to support PHP8: laruence/php-lua#47 Signed-off-by: Herve Codina <herve.codina@bootlin.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static methods like Lua::getVersion shouldn't use ZEND_ACC_ALLOW_STATIC but most likely use ZEND_ACC_STATIC. This PR addresses the issue (which otherwise blocks compilation against PHP8)