Allow building on FreeBSD variants #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that's converting test shell scripts to run in a bash-agnostic /bin/sh way.
that's converting test shell scripts to run in a bash-agnostic /bin/sh way.
Fix typo in path
Collaborator
|
Thanks. Similar to the tang PR (latchset/tang#60), this one also looks good, but the |
Contributor
Author
|
Still hoping these changes are acceptable. And apologies for the churn in commits - I aimed at the wrong branch and since this is still pending they landed here (and have been reverted.) |
sergio-correia
approved these changes
Apr 28, 2021
Collaborator
sergio-correia
left a comment
sergio-correia
left a comment
There was a problem hiding this comment.
Thanks, this looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow building the project on FreeBSD and it's variants. The README is changed to note describe the build. The bulk of the changes are to tests to remove bash dependencies in the tests since bash is not guaranteed to be installed on FreeBSD. While those changes could be separated out into separate files or have the build generate bash and non-bash from a common .in file, since the changes should work fine on linux it seemed better to just just have the one source. I am, of course, completely open to making changes or separating the pull request into smaller pieces if that's desired.