feat: bumped to libsqlite3-sys=0.30.1 to support sqlite 3.46#3382
Merged
abonander merged 2 commits intolaunchbadge:mainfrom Jul 28, 2024
Merged
feat: bumped to libsqlite3-sys=0.30.1 to support sqlite 3.46#3382abonander merged 2 commits intolaunchbadge:mainfrom
libsqlite3-sys=0.30.1 to support sqlite 3.46#3382abonander merged 2 commits intolaunchbadge:mainfrom
Conversation
Collaborator
|
@CommanderStorm if you rebase it should fix CI. |
CommanderStorm
changed the title
libsqlite3-sys=0.30.1libsqlite3-sys=0.30.1 to support sqlite 3.46
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Resolves #3369 (comment)
From a functionality wise, none of the changes in https://github.com/rusqlite/rusqlite/releases seem like they can break sqlx.
Maybe some of them could (I don't think "we"should) be used by the testing macro, IF that macro were sqlite-only.
On a motivation note, this comes with sqlite 3.46.
=> The query planner is now a bit smarter/more optimised. This might be significant for bulk inserts.
@BSteffaniak is there some feature that I am missing which is motivating your use?