Update libsqlite3-sys to 0.34.0 for SQLite 3.49.2 and rusqlite compatibility#3922
Closed
kriswuollett wants to merge 2 commits intolaunchbadge:mainfrom
Closed
Update libsqlite3-sys to 0.34.0 for SQLite 3.49.2 and rusqlite compatibility#3922kriswuollett wants to merge 2 commits intolaunchbadge:mainfrom
kriswuollett wants to merge 2 commits intolaunchbadge:mainfrom
Conversation
kriswuollett
force-pushed
the
libsqlite3-sys-0.34.0
branch
2 times, most recently
from
350f5e5 to
b479c80
Compare
Collaborator
|
@kriswuollett I found a workaround for the build failure and reported the issue upstream: rusqlite/rusqlite#1716 |
Collaborator
|
TL;DR: just add this to [build-dependencies]
# FIXME: https://github.com/rusqlite/rusqlite/issues/1716
# force `prettyplease` to a minimum version that supports C-string literals
prettyplease = "0.2.18" |
Collaborator
|
Actually, as a result of rusqlite/rusqlite#1716, they just released Strictly speaking, their MSRV puts them one release ahead of us, but we can probably safely guarantee that it will work with 1.87.0. |
kriswuollett
force-pushed
the
libsqlite3-sys-0.34.0
branch
from
62830b6 to
78c0c13
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
fixes #3921 (compatibility with rusqlite in same workspace)
Is this a breaking change?
TBD to rely upon CI