sqlx-sqlite: relax libsqlite3-sys constraint to allow 0.36.x#4161
Merged
abonander merged 1 commit intolaunchbadge:mainfrom Feb 12, 2026
Merged
sqlx-sqlite: relax libsqlite3-sys constraint to allow 0.36.x#4161abonander merged 1 commit intolaunchbadge:mainfrom
abonander merged 1 commit intolaunchbadge:mainfrom
Conversation
gferon
pushed a commit
to gferon/sqlx
that referenced
this pull request
Feb 28, 2026
gferon
pushed a commit
to gferon/sqlx
that referenced
this pull request
Feb 28, 2026
kriswuollett
added a commit
to appbiotic/tp-launchbadge-sqlx
that referenced
this pull request
Apr 18, 2026
…compat
SQLCipher builds with SQLITE_OMIT_LOAD_EXTENSION (and does not include
sqlite3_unlock_notify), so sqlx-sqlite's unconditional imports of
sqlite3_load_extension and sqlite3_unlock_notify fail to link against a
SQLCipher-backed libsqlite3. This fork adds two opt-in Cargo features on
sqlx-sqlite:
- `load-extension` — gates SqliteLoadExtensionMode, the load-extension
helper fn, and the per-connection extension-loading block. When the
feature is off and a consumer has called
SqliteConnectOptions::extension(), establish() returns
Error::InvalidArgument rather than silently ignoring the registration.
- `unlock-notify` — gates sqlx-sqlite's unlock_notify module and the
SQLITE_LOCKED_SHAREDCACHE match arm in connection and statement step
loops. Forwards to libsqlite3-sys/unlock_notify so the symbol is
compiled in only when the feature is requested.
Also widens the libsqlite3-sys version bound from =0.30.1 to
>=0.30.1, <0.38 so the crate can coexist with rusqlite 0.39+ (which
requires libsqlite3-sys 0.37) in the same 'links = "sqlite3"' graph.
Carried in the appbiotic fork; the widen + gating pattern follows
launchbadge/sqlx PR launchbadge#4161 and is intended to be upstreamable.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Fixes #4160
Is this a breaking change?
No