This repository was archived by the owner on May 30, 2024. It is now read-only.
Conversation
…ns, fix LDFeatureStore.close return value
…hods-to-typescript-definitions [ch20232] Add flag util methods to typescript definitions
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/npm:cryptiles:20180710
[Snyk] Fix for 1 vulnerable dependencies
remove npm dependency on "crypto", use built-in version instead
treat HTTP 400 as a recoverable error
# Conflicts: # package-lock.json
update doc comment for new waitForInitialization behavior
fix waitForInitialization to always resolve with a value
Update LDFeatureStore type definition for versioned data kind
add new version of allFlags() that captures more metadata
add unit tests for polling and requestor
add ability to skip Redis tests
doc updates + build improvements
# Conflicts: # package-lock.json
update package name + fix some test stuff
…ulnerability with 'extend' (#140) * bump request to resolve a security vulnerability with extend * remove incorrect build step * update language
# Conflicts: # package-lock.json # package.json
update doc comment for track() with metricValue
# Conflicts: # CHANGELOG.md
fix ruleIndex in rule match reason
bwoskow-ld
approved these changes
Oct 10, 2019
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Dec 11, 2019
use CircleCI for Windows build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[5.9.1] - 2019-10-10
Fixed:
RULE_MATCH, theruleIndexproperty was always being set to zero rather than to the actual rule index. Note that it is always best to look atruleIdrather thanruleIndex, since it will never change even if rules are added or deleted.