Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.

Fix type defs (implicit any) #64

Merged
zmdavis merged 1 commit into from
Jun 26, 2017
Merged

Fix type defs (implicit any) #64

zmdavis merged 1 commit into from
Jun 26, 2017

Conversation

@nvenegas
Copy link

@nvenegas nvenegas commented Jun 22, 2017 •
edited
Loading

Fixes

> tsc

node_modules/ldclient-node/index.d.ts(311,31): error TS7006: Parameter 'err' implicitly has an 'any' type.

zmdavis
zmdavis approved these changes Jun 26, 2017
View reviewed changes
Copy link
Contributor

@zmdavis zmdavis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nic. I think we missed this because we were running without noImplicitAny set to true. I'll look into adding a tsconfig.json file as well.

@zmdavis zmdavis merged commit 25563e1 into launchdarkly:master Jun 26, 2017
eli-darkly added a commit that referenced this pull request Mar 27, 2018
@eli-darkly
Merge pull request #64 from launchdarkly/eb/ch15469/flush-unhandled-p…
f0c5402 
…romise

avoid unhandled promise rejection when automatically flushing
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@zmdavis zmdavis zmdavis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nvenegas @zmdavis