Skip to content

Conversation

@csuvajit
Copy link
Contributor

@csuvajit csuvajit commented Oct 4, 2020

No description provided.

@appellation
Copy link
Member

This should probably be handled more gracefully, since many of those events are recoverable simply by reconnecting. I'm not sure if Lavalink does anything on its end to handle that, but if not it's definitely something we can do on the client library side to make the developer experience much nicer.

@ridays2001
Copy link

I think Lavalink does it because the people using the original Java version don't experience this problem.

@appellation
Copy link
Member

I think Lavalink does it because the people using the original Java version don't experience this problem.

Does this mean that Lavalink only forwards unrecoverable close codes? The Lavalink documentation on this subject is a bit sparse, and it's hard for me to test personally since I no longer use it; however, the implication here is that it sends any and all voice websocket close events.

image

@csuvajit
Copy link
Contributor Author

csuvajit commented Oct 4, 2020

I should have explained! This is not about close code.
If we kick the bot from voice channel, lavalink emits WebSocketClosedEvent event which skips the currently playing song.
A month ago @ridays2001 shared this issue in Lavalibs server.

image

@ridays2001
Copy link

And the song keeps on playing even when it's supposed to be paused. I didn't notice it before. But, after some debugging, I found that out. Once the bot leaves the VC, even if the song was paused, it automatically resumes the song in the background... @csuvajit told me that this WebSocketClosed caused the problem...

@ridays2001
Copy link

ridays2001 commented Oct 4, 2020

But, when I asked around in the JDA server, I found out that people using original Java client don't experience this issue... That's why I thought that it's fixed in Lavalink

@appellation
Copy link
Member

Ah, sure, that makes sense. Thank you for clarifying.

@appellation appellation merged commit bafe889 into lavalibs:master Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants