Skip to content

fixed some issues#1

Merged
freyacodes merged 4 commits into
lavalink-devs:masterfrom
topi314:master
Dec 21, 2021
Merged

fixed some issues#1
freyacodes merged 4 commits into
lavalink-devs:masterfrom
topi314:master

Conversation

@topi314
Copy link
Copy Markdown
Member

@topi314 topi314 commented Dec 19, 2021

if you use the gradle run command the logs & application.yml should be excluded

sourceCompatibility shouldprob always be 11 as thats what lavalink is compiled with

the Test class also did not fulfill the interface anymore

@topi314
Copy link
Copy Markdown
Member Author

topi314 commented Dec 20, 2021

including shadow to build fat jars should also be important

idk if that requires additional setup for jitpack tho

@topi314
Copy link
Copy Markdown
Member Author

topi314 commented Dec 20, 2021

@topi314
Copy link
Copy Markdown
Member Author

topi314 commented Dec 20, 2021

another problem with the current setup is that plugins get big(70MB) in size due to the com.github.freyacodes.lavalink:Lavalink-Server dependency

commenting out and then building is my current fix which is meh

Comment thread src/main/java/org/example/plugin/Test.java Outdated
Comment thread build.gradle
Comment thread build.gradle
group 'org.example'
version '1.0'
mainClassName = "org.springframework.boot.loader.JarLauncher"
sourceCompatibility = 11
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I had some issues with this in Jitpack. Does Jitpack still compile this project?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see...

* What went wrong:
Execution failed for task ':compileJava'.
> invalid source release: 11

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently you need to set it to java 11 in your jitpack.yml
lemme try that
jitpack/jitpack.io#4022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freyacodes
Copy link
Copy Markdown
Member

commenting out and then building is my current fix which is meh

There's probably a way of fixing this. Gradle's dependency configuration is extendable

@topi314
Copy link
Copy Markdown
Member Author

topi314 commented Dec 20, 2021

commenting out and then building is my current fix which is meh

There's probably a way of fixing this. Gradle's dependency configuration is extendable

I hoped you know how 👀

@topi314 topi314 requested a review from freyacodes December 20, 2021 20:52
@freyacodes
Copy link
Copy Markdown
Member

I hoped you know how

I have an idea of how to do it but completing this project and writing my report takes priority

@freyacodes freyacodes merged commit 3e02a57 into lavalink-devs:master Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants