fixed some issues#1
Conversation
|
including shadow to build fat jars should also be important idk if that requires additional setup for jitpack tho |
|
another problem with the current setup is that plugins get big(70MB) in size due to the commenting out and then building is my current fix which is meh |
| group 'org.example' | ||
| version '1.0' | ||
| mainClassName = "org.springframework.boot.loader.JarLauncher" | ||
| sourceCompatibility = 11 |
There was a problem hiding this comment.
I think I had some issues with this in Jitpack. Does Jitpack still compile this project?
There was a problem hiding this comment.
I see...
* What went wrong:
Execution failed for task ':compileJava'.
> invalid source release: 11
There was a problem hiding this comment.
apparently you need to set it to java 11 in your jitpack.yml
lemme try that
jitpack/jitpack.io#4022
There was a problem hiding this comment.
that seems to have fixed it!
6445d75 (#1)
https://jitpack.io/com/github/TopiSenpai/lavalink-plugin-template/-6445d75ebb-1/build.log
There's probably a way of fixing this. Gradle's dependency configuration is extendable |
I hoped you know how 👀 |
I have an idea of how to do it but completing this project and writing my report takes priority |
if you use the gradle run command the
logs&application.ymlshould be excludedsourceCompatibilityshouldprob always be 11 as thats what lavalink is compiled withthe Test class also did not fulfill the interface anymore