feat: add annotations and geo data #32
Open
+258
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump `virtuoso` to a version support geosparql, follow the steps in the README[1] to update - Removes the superfluous `+` symbols in the virtuoso's configuration. These caused these lines to be ignored and thus not loading the necessary plugins. [1] https://github.com/redpencilio/docker-virtuoso?tab=readme-ov-file#upgrading
mirdono
force-pushed
the
feat/add-geo-and-annotation-to-resources
branch
from
10e0d55 to
2b616dd
Compare
mirdono
force-pushed
the
feat/add-geo-and-annotation-to-resources
branch
from
2b616dd to
0a3c160
Compare
Rahien
approved these changes
Jan 7, 2026
| :resource-base (s-url "http://data.lblod.info/id/memberships/")) | ||
|
|
||
| (define-resource location () | ||
| (define-resource location-temp () |
Member
Author
There was a problem hiding this comment.
I ran into issues when I defined the other location resource type for dct:Location in geo.lisp. Renaming the one defined here was a quick fix at the time as it is not (yet) used in the frontend.
| :resource-base (s-url "http://data.lblod.info/id/locations/geometry/") | ||
| :on-path "geometries") | ||
|
|
||
| ;; TODO: Add: `schema:TouristAttraction', `Perceel:Perceel', and `wikidata:Q2785216'? |
Contributor
There was a problem hiding this comment.
probably not for the pilot? check with business?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #27 to provide a public endpoint for the app's annotations with geographical information. More specifically, this extends the configuration for the resource and dispatcher services with the appropriate resource definitions and routes respectively. Furthermore, this bumps the used
docker-virtuosoto a version supporting geosparql and updates its configurations to load the appropriate plugins. Finally, this adds a migration inserting some example data for demonstration and testing purposes.How to test
This PR involves upgrading the version of the virtuoso service. For this follow the upgrade instructions in the
docker-virtuosoREADME. Note, make sure you already started the virtuoso service before switching to this PR's branch.Afterwards, make sure to restart the
resourcesanddispatcherservices such that they load their updated configurations. To load the example data into the app simply start the migrations service.Notes
Related PRs
Related tickets