Skip to content

Allow environment var GOGC=<percent> to override hard-coded SetGCPercent(10)#45

Merged
roylee17 merged 1 commit intolbryio:masterfrom
moodyjon:gogc_env_var
Jun 3, 2022
Merged

Allow environment var GOGC=<percent> to override hard-coded SetGCPercent(10)#45
roylee17 merged 1 commit intolbryio:masterfrom
moodyjon:gogc_env_var

Conversation

@moodyjon
Copy link
Collaborator

@moodyjon moodyjon commented Jun 3, 2022

Unbundled from PR #43

See that for usage/testing. (TODO)

The default (10) only lets heap grow 10% before triggering GC. Running with (for example) "GOGC=100" will reduce CPU usage while heap is allowed to fluctuate more.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2434997880

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 51.793%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lbcd.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
peer/peer.go 2 76.31%
btcec/signature.go 3 92.82%
Totals Coverage Status
Change from base Build 2403229780: 0.01%
Covered Lines: 22413
Relevant Lines: 43274

💛 - Coveralls

@roylee17 roylee17 merged commit 92a7a20 into lbryio:master Jun 3, 2022
@roylee17
Copy link
Collaborator

roylee17 commented Jun 3, 2022

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants