Decouple configs #245
Merged
Decouple configs #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update test.
Update test branch.
Merge main into test
Collaborator
Author
|
Fixes #244. |
thisismattmiller
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RandyBarry this is the decoupling work that we discussed last week.
I added all the minor Cyrillic languages formerly grouped under
cyrillic_generic(and also removed some duplicates). Now those have their own index and menu entry while referring to the samecyrillic_generictable.I also associated MARC codes for those languages. There may be some redundancy, e.g. I see
tuva_cyrillic(no MARC code) andtuvinian_cyrillic(tyv), and alsoromani_cyrillicandromany_cyrillic. I left them in place for your review.Maybe in a later step after merging this you can remove the empty config files for Devanagari and other scripts, and replace them with refernces to the Devanagari generic table.