Fix double initialisation of variables in ASR #1629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgdp1807
commented
Mar 26, 2023
|
|
||
| if( init_expr && current_body) { | ||
| if( init_expr && current_body && | ||
| (is_runtime_expression || !is_variable_const)) { |
Collaborator
Author
There was a problem hiding this comment.
Only those variables will be initialised by converting to assignments which are non-constant or have a runtime expressions. Also an error is thrown if a constant variable is not initialised at declaration (see lines 2215 to 2219).
certik
reviewed
Mar 27, 2023
src/libasr/asr_verify.cpp
Outdated
| + std::string(x.m_name) + ")"); | ||
|
|
||
| if( symtab->parent == nullptr ) { | ||
| // For nowRestrict this check only to variables which are present |
Contributor
There was a problem hiding this comment.
Suggested change
| // For nowRestrict this check only to variables which are present | |
| // For now restrict this check only to variables which are present |
certik
approved these changes
Mar 27, 2023
Contributor
certik
left a comment
certik
left a comment
There was a problem hiding this comment.
I think that this is good, thanks for fixing it and adding a test!
I suggest we merge it, and if there are more issues, we'll tackle it as we discover it.
Collaborator
Author
|
Okay. Let me check if verify changes work with LFortran. Then I will merge both the PRs. |
1. Only those variables which are constant and have a compile time initialisation expression will have non-nullptr values for m_symbolic_value and m_value 2. Rest all will be converted to assignment statements.
certik
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1626