Skip to content

Accept dtype argument in numpy.array #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
czgdp1807 merged 3 commits into from
Aug 2, 2023
Merged

Accept dtype argument in numpy.array #2118

czgdp1807 merged 3 commits into from
Aug 2, 2023

Conversation

@czgdp1807
Copy link
Collaborator

@czgdp1807 czgdp1807 commented Jul 7, 2023

Closes #2089

@certik
Copy link
Contributor

certik commented Jul 7, 2023

Let's add some tests.

@czgdp1807 czgdp1807 marked this pull request as ready for review August 2, 2023 07:52
certik
certik approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine.

@czgdp1807 czgdp1807 merged commit 9aefff4 into lcompilers:main Aug 2, 2023
@czgdp1807 czgdp1807 deleted the array branch August 2, 2023 11:55
@certik
Copy link
Contributor

certik commented Aug 2, 2023

This almost fixes #1790, we just need to implement the rest of the dtypes.

@certik certik mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@certik certik certik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bugs with numpy.array

2 participants

@czgdp1807 @certik