Get macOS test working again #2502
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It hangs.... So the issue is definitely not caused by #2452. Rather, it's either caused by something introduced before that PR, or some changes in the GitHub Actions or Conda environments. |
Contributor
Author
|
Testing an even older commit at #2504 |
Contributor
Author
|
We figured it out in #2520. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2455.
The first macOS failure in master happened in #2452. This PR reverts LPython to the commit before that. We'll see if it reliably passes.
If it passes, then #2452 must have broken it.
If it doesn't pass, then something in the GitHub Actions or Conda environment changed.