Implemented mangling for c back-end as per issue #2359 . #2546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certik
reviewed
Feb 18, 2024
certik
reviewed
Feb 19, 2024
certik
reviewed
Feb 19, 2024
Contributor
Author
|
I have refactored the changes as per requirements. |
Contributor
Author
|
@certik Are there any other improvements required? |
Collaborator
Thirumalai-Shaktivel
left a comment
Thirumalai-Shaktivel
left a comment
There was a problem hiding this comment.
Looks good. If it works add a test in integration_tests and register in CMakeLists. Later, mark it as ready for review.
Contributor
Author
|
I have implemented all the suggested changes. Some of the tests failed due to mamba |
Thirumalai-Shaktivel
approved these changes
Mar 23, 2024
Collaborator
Thirumalai-Shaktivel
left a comment
Thirumalai-Shaktivel
left a comment
There was a problem hiding this comment.
LGTM, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the
unique_symbolspass to mangle reserved keywords for c backend.