Add support for accessing values from data-structures contained within Const
#2560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Trying to access a key from a
Const dictthrew aSemanticErrorstating type mismatch. AnASR pass errorwas thrown when trying to access values from aConst list,Const tupleandConst str. This was chiefly because the case of aConstvalue was not addressed in handling subscript indices.Fix
Check for
Constwhen visiting subscript indices and handle item access through the contained type in thellvmback-end.Throw a
SemanticErrorfor immutable types liketupleandstr.Tuple
String
Dictionary
List
Note
The
getattribute ofConst dictstill throws aSemanticErrornow. I will push the fix for that in a separate PR.