refactor (asr): rename symbol StructType to Struct and ttype Struct to StructType
#2740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Thirumalai Shaktivel <74826228+Thirumalai-Shaktivel@users.noreply.github.com>
Co-authored-by: Thirumalai Shaktivel <74826228+Thirumalai-Shaktivel@users.noreply.github.com>
Collaborator
Thirumalai-Shaktivel
left a comment
Thirumalai-Shaktivel
left a comment
There was a problem hiding this comment.
Otherwise looks good to merge, thank you!
Co-authored-by: Thirumalai Shaktivel <74826228+Thirumalai-Shaktivel@users.noreply.github.com>
Co-authored-by: Thirumalai Shaktivel <74826228+Thirumalai-Shaktivel@users.noreply.github.com>
Co-authored-by: Thirumalai Shaktivel <74826228+Thirumalai-Shaktivel@users.noreply.github.com>
Co-authored-by: Thirumalai Shaktivel <74826228+Thirumalai-Shaktivel@users.noreply.github.com>
fixed conflicting name issue
certik
reviewed
Jun 20, 2024
| return ; | ||
| } | ||
| PassUtils::PassVisitor<Struct>::visit_Function(x); | ||
| PassUtils::PassVisitor<StructType>::visit_Function(x); |
Contributor
There was a problem hiding this comment.
This should probably be just a Struct, since it is a template parameter.
certik
approved these changes
Jun 20, 2024
Contributor
certik
left a comment
certik
left a comment
There was a problem hiding this comment.
I think this is fine. I left a minor comment. I am going to merge it now, to unblock Tanay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename symbol
StructTypetoStructand ttypeStructtoStructType.