refactor: update PLAN.md and remove dead code#333
Merged
Conversation
Remove methods that were wrappers to Lexer methods, now unused since parse_word() uses token-based parsing: - _scan_single_quote - _scan_bracket_expression - _parse_ansi_c_quote - _parse_locale_string Remove unused utility methods: - _is_word_boundary_before - _is_comment_start_context - _lookahead_keyword - _skip_keyword - _lookahead_for_esac_parser - _skip_backtick_parser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed methods
Wrappers to Lexer methods, now unused since parse_word() uses tokens:
_scan_single_quote_scan_bracket_expression_parse_ansi_c_quote_parse_locale_stringUnused utility methods:
_is_word_boundary_before_is_comment_start_context_lookahead_keyword_skip_keyword_lookahead_for_esac_parser_skip_backtick_parserAll 4515 tests pass (Python and JavaScript).