Fix DMD bugzilla 14903 (proper args destruction)#1044
Closed
kinke wants to merge 1 commit intoldc-developers:merge-2.067from
Closed
Fix DMD bugzilla 14903 (proper args destruction)#1044kinke wants to merge 1 commit intoldc-developers:merge-2.067from
kinke wants to merge 1 commit intoldc-developers:merge-2.067from
Conversation
A backport of my upstream PR, which won't get merged due DDMD. Let's not wait until LDC supports the front-end in D to fix this serious bug. The additional diff won't be relevant anymore anyway. I've extended the upstream PR by proper evaluation order for array ops, compatible with our args evaluation order in tocall.cpp.
Member
Author
|
I still need to add the tests from the upstream PR (+ new ones with throwing dtors) to dmd-testsuite. @klickverbot : glad to say that all 5 original test cases work flawlessly on Win64 too with this and your EH rewrite! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A backport of my upstream PR dlang/dmd#4885, which won't get merged due to DDMD.
Let's not wait until LDC supports the front-end in D to fix this serious bug. The additional diff won't be relevant anymore anyway.
I've extended the upstream PR by proper evaluation order for array ops, compatible with our args evaluation order in tocall.cpp.