Enable cross-static-lib generation for LLVM 3.9+#2030
Merged
kinke merged 7 commits intoldc-developers:masterfrom Apr 8, 2017
Merged
Enable cross-static-lib generation for LLVM 3.9+#2030kinke merged 7 commits intoldc-developers:masterfrom
kinke merged 7 commits intoldc-developers:masterfrom
Conversation
kinke
force-pushed
the
crossLib
branch
2 times, most recently
from
237ecf3 to
eeb0c80
Compare
kinke
changed the title
Member
Author
|
Replacing objects in existing libs (and keeping old non-replaced members) re-added. |
By directly integrating LLVM's `llvm-lib.exe` driver to generate static libs for MSVC targets and a stripped-down version of the `llvm-ar` tool for the other targets. Introduce command-line option `-archiver=<file>` to allow the user to specify an external archiver to be invoked.
Member
Author
|
|
For invoking MS tools such as link.exe and lib.exe, which require compatible PATH, LIB, LIBPATH etc. We previously wrapped the invokation of the tool with a batch file taking care of setting up the environment and then calling the actual tool. I changed this to first invoke another batch file setting up its environment and then dumping all environment variables to a file. LDC then parses this file and updates its own environment variables. Later spawned child processes then inherit the updated environment, and the tools will be located by LLVM in updated PATH. This allows LDC to keep track of the used Visual C++ installation (and could so set up additional runtime libs required since VS 2015, something we would have needed some time back when we still supported VS 2013). It's also required as a prerequisite for integrating LLD as in-process linker on Windows. I quickly looked into the option of setting up the environment manually, but the MS batch files are full of quirks, mixtures of registry and file-system lookups, checking for existence of misc. headers to filter out bogus installations etc. With VS 2017, there's nothing in the registry at all anymore (at least for the Build Tools); MS expose a COM interface for querying the VS installer... But at least they still provide the batch files.
Member
Author
|
The 3rd commit seems to work fine (has to be tested manually, AppVeyor uses a preset environment) and paves the way for integrating LLD. Enough for tonight though. ;) |
And get rid of redundant cmdline option -archiver.
And warn if no Visual C++ installation is detected, similar to the now suppressed warning issued by the batch file.
kinke
changed the title
Member
Author
|
Interesting - this time the spurious OSX failure/segfault wasn't |
Member
Author
|
Any concerns? To me, this is currently mostly a shortcut for guys having to cross-link externally. Handling a single static lib instead of a multitude of objects is just more convenient. And for MSVC targets, I noticed that the static lib file size for a Phobos-hello-world is reduced by a very rough 10% [IIRC] compared to VS 2015 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By directly integrating LLVM's
llvm-lib.exedriver to generate static libs for MSVC targets and a heavily stripped-down version of thellvm-artool for the other targets.For the moment, just testing if it basically works on Linux and OSX too (works fine here on Win64; able to produce libs for x86 and x86_64 Linux...) and which older LLVM versions aren't supported. I removed the
llvm-arlogic for modifying an existing lib (insertion order...), I guess it'll have to be put in again for the final implementation. :/