Add helper function append to runtime cmakescript#2256
Closed
JohanEngelen wants to merge 1 commit intoldc-developers:masterfrom
Closed
Add helper function append to runtime cmakescript#2256JohanEngelen wants to merge 1 commit intoldc-developers:masterfrom
append to runtime cmakescript#2256JohanEngelen wants to merge 1 commit intoldc-developers:masterfrom
Conversation
…ile is used directly (instead of included by the main LDC cmakescript)
Member
|
I fixed this already in #2253 superseding the script. |
Member
Author
|
Ah ok, so let's pull that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
appendfunction is missing when the runtime cmakescript is used directly (instead of included by the main LDC cmakescript).With this PR, the
build-ldc-runtime.shworks for me straight from mybuild/bindir and specifying my git checkout asLDC_SRC_DIR, nice!