Emit ModuleInfos as COMDATs again#2409
Merged
kinke merged 1 commit intoldc-developers:masterfrom Nov 14, 2017
Merged
Conversation
Reverts this functional change introduced by ldc-developers/ldc@3f38f971. I overlooked this because `setLinkage({<linkage>, false}, <symbol>` does NOT clear the COMDAT if previously set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts this functional change introduced by 3f38f971. I overlooked this because
setLinkage({<linkage>, false}, <symbol>)does NOT clear the COMDAT if previously set.