Solaris: fix assert for betterC build.#2566
Merged
dnadlinger merged 2 commits intoldc-developers:masterfrom Feb 9, 2018
Merged
Solaris: fix assert for betterC build.#2566dnadlinger merged 2 commits intoldc-developers:masterfrom
dnadlinger merged 2 commits intoldc-developers:masterfrom
Conversation
JohanEngelen
reviewed
Feb 8, 2018
gen/llvmhelpers.cpp
Outdated
| } else if (global.params.targetTriple->isOSSolaris()) { | ||
| const auto irFunc = gIR->func(); | ||
| const auto funcName = | ||
| irFunc && irFunc->decl ? irFunc->decl->toPrettyChars() : ""; |
Member
There was a problem hiding this comment.
can you add parens here, to avoid relying on operator precedence rules. (i know it is a copy from a few lines above)
Member
|
LGTM (with the nit). A lit test would be nice for betterC assert function name (do we have one already?). |
Member
|
A DMD test makes sure a betterC program with assertions can be linked. |
nykytenko
force-pushed
the
illumos-betterc-assert
branch
from
b8c6212 to
a8cf534
Compare
joakim-noah
pushed a commit
that referenced
this pull request
Jun 11, 2018
* Solaris: fix assert for betterC build. * Added parens to avoid relying on operator precedence rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.