Make interface thunks forward variadic args#2630
Merged
kinke merged 1 commit intoldc-developers:masterfrom Apr 10, 2018
Merged
Conversation
This fixes issue ldc-developers#2613.
| call->setCallingConv(irFunc->getCallingConv()); | ||
| call->setTailCallKind(llvm::CallInst::TCK_Tail); | ||
| call->setTailCallKind(thunk->isVarArg() ? llvm::CallInst::TCK_MustTail | ||
| : llvm::CallInst::TCK_Tail); |
Member
There was a problem hiding this comment.
is there a reason why this shouldn't always be a tail call?
Member
Author
There was a problem hiding this comment.
I got Phobos compile errors (std.regex) when always using must-tail, so I switched to this without further investigation.
Member
There was a problem hiding this comment.
Hmm ok. LGTM otherwise. Perhaps we can investigate at some later moment
Member
There was a problem hiding this comment.
Looks like musttail is causing problems on PowerPC: #2686
This was referenced Apr 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #2613.