Fix compilation issues on 64-bit macOS with DMD host compiler >= 2.079#2704
Merged
kinke merged 2 commits intoldc-developers:masterfrom May 21, 2018
Merged
Fix compilation issues on 64-bit macOS with DMD host compiler >= 2.079#2704kinke merged 2 commits intoldc-developers:masterfrom
kinke merged 2 commits intoldc-developers:masterfrom
Conversation
... due to its D `long` C++ mangling change.
Member
|
This shows how bad the mangling interop has become :( we should point the DMD folks to it. |
Member
|
LGTM |
Member
Author
I told them ~1 month ago that |
Member
|
|
Member
Author
|
Ah yeah apparently so (haven't really given that PR's changes a proper look before). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #2703.