Conversation
Merged
Contributor
Author
|
CI looks good, only some timeouts, as usual. |
Contributor
Author
|
@kinke, please merge before the release if everything seems okay. All changes here should be scoped to Android, so shouldn't affect any other platform, as the CI shows. |
Contributor
Author
|
Crap, I missed a tweak needed for ARM to work with the new LLVM 7 emulated TLS, just saw it when building the tests to check the final 1.12 release. Oh well, I doubt anyone's using Android/ARM anyway, will just update the release notes and wiki to notify any potential user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple more small tweaks needed to
rt.sections_androidandstd.mathfor Android/x64 to cross-compile out of the box, but no big need to get those merged before the release.