Fix if-statement elision on constant true/false condition, for condit…#4559
Merged
JohanEngelen merged 2 commits intoldc-developers:masterfrom Jan 10, 2024
Merged
Fix if-statement elision on constant true/false condition, for condit…#4559JohanEngelen merged 2 commits intoldc-developers:masterfrom
JohanEngelen merged 2 commits intoldc-developers:masterfrom
Conversation
…ion expressions that are more complex than a simple integer. Resolves issue ldc-developers#4556
Member
|
Is the Circle CI failure caused by using the distro-LLVM v11.0.0, whereas the vanilla-LLVM job uses v11.1.0? Edit: In which case we could presumably simply use |
Member
Author
Yep. The testcase is a bit strange too, let me think about it. |
… the right thing regardless of codegen optimization or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ion expressions that are more complex than a simple integer.
Resolves issue #4556