Skip to content

Experimental: Don't reverse parameter order for extern(D) on x86_64. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kinke wants to merge 1 commit into from
Closed

Experimental: Don't reverse parameter order for extern(D) on x86_64. #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 26 additions & 11 deletions std/internal/digest/sha_SSSE3.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,8 +586,8 @@ version(USE_SSSE3)
{
/*
* Parameters:
* RSI contains pointer to state
* RDI contains pointer to input buffer
* RDI (Win64: RCX) contains pointer to state
* RSI (Win64: RDX) contains pointer to input buffer
*
* Stack layout as follows:
* +----------------+
Expand All @@ -603,15 +603,30 @@ version(USE_SSSE3)
* | Wi+Ki | <- RSP
* +----------------+ <- 16byte aligned
*/
return [// Save registers according to calling convention
"push RBP",
"push RBX",
// Save parameters
"mov "~STATE_PTR~", RSI", //pointer to state
"mov "~BUFFER_PTR~", RDI", //pointer to buffer
// Align stack
"sub RSP, 4*16+8",
];
version(Win64)
{
return [// Save registers according to calling convention
"push RBP",
"push RBX",
// Save parameters
"mov "~STATE_PTR~", RCX", //pointer to state
"mov "~BUFFER_PTR~", RDX", //pointer to buffer
// Align stack
"sub RSP, 4*16+8",
];
}
else
{
return [// Save registers according to calling convention
"push RBP",
"push RBX",
// Save parameters
"mov "~STATE_PTR~", RDI", //pointer to state
"mov "~BUFFER_PTR~", RSI", //pointer to buffer
// Align stack
"sub RSP, 4*16+8",
];
}
}
}

Expand Down
14 changes: 9 additions & 5 deletions std/math.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1168,8 +1168,8 @@ real atan2(real y, real x) @trusted pure nothrow @nogc
{
asm pure nothrow @nogc {
naked;
fld real ptr [RDX]; // y
fld real ptr [RCX]; // x
fld real ptr [RCX]; // y
fld real ptr [RDX]; // x
fpatan;
ret;
}
Expand Down Expand Up @@ -2381,12 +2381,16 @@ version (none) {
{
version (Win64)
{
// RCX: pointer to creal result
// RDX: pointer to y
asm pure nothrow @nogc
{
naked;
fld real ptr [ECX];
fld real ptr [RDX]; // y
fsincos;
fxch ST(1), ST(0);
fstp real ptr [RCX];
fstp real ptr 16[RCX];
ret;
}
}
Expand Down Expand Up @@ -3582,9 +3586,9 @@ real scalbn(real x, int n) @trusted nothrow @nogc
{
asm pure nothrow @nogc {
naked ;
mov 16[RSP],RCX ;
mov 16[RSP],RDX ;
fild word ptr 16[RSP] ;
fld real ptr [RDX] ;
fld real ptr [RCX] ;
fscale ;
fstp ST(1) ;
ret ;
Expand Down