Skip to content

Conversation

@someaddons
Copy link
Contributor

@someaddons someaddons commented Jan 4, 2026

Closes #
Closes #

Changes proposed in this pull request

  • Improve undo to only skip on wrong block instead of blockstate

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

// Only revert block changes which this operation caused
if (world.getBlockState(entry.getKey()) != entry.getValue().getPostState())
if (world.getBlockState(entry.getKey()).getBlock() != entry.getValue().getPostState().getBlock()
|| entry.getValue().getPostTE() != world.getBlockEntity(entry.getKey()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the TE reference check?

@Raycoms Raycoms merged commit 2d3218c into version/main Jan 5, 2026
5 checks passed
@Raycoms Raycoms deleted the undo branch January 5, 2026 11:56
@Raycoms
Copy link
Contributor

Raycoms commented Jan 5, 2026

Please port

someaddons added a commit that referenced this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants