Skip to content

Conversation

@themathqueen
Copy link
Collaborator

@themathqueen themathqueen commented Dec 26, 2025


This came up during review of #33282.

Open in Gitpod

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Dec 26, 2025
@github-actions
Copy link

github-actions bot commented Dec 26, 2025

PR summary 51192f7a45

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Module.LinearMap.End 276 277 +1 (+0.36%)
Mathlib.Algebra.Central.End 811 812 +1 (+0.12%)
Import changes for all files
Files Import difference
19 files Mathlib.Algebra.Category.Grp.ZModuleEquivalence Mathlib.Algebra.Category.ModuleCat.Basic Mathlib.Algebra.Category.ModuleCat.Colimits Mathlib.Algebra.Category.ModuleCat.FilteredColimits Mathlib.Algebra.Category.ModuleCat.Semi Mathlib.Algebra.Central.End Mathlib.Algebra.Module.Equiv.Basic Mathlib.Algebra.Module.LinearMap.End Mathlib.Algebra.Order.Module.Equiv Mathlib.CategoryTheory.Abelian.GrothendieckCategory.Coseparator Mathlib.CategoryTheory.Adjunction.Additive Mathlib.CategoryTheory.Generator.Abelian Mathlib.CategoryTheory.Generator.Preadditive Mathlib.CategoryTheory.Limits.ConcreteCategory.WithAlgebraicStructures Mathlib.CategoryTheory.Linear.Yoneda Mathlib.CategoryTheory.Preadditive.Yoneda.Basic Mathlib.LinearAlgebra.Finsupp.Defs Mathlib.LinearAlgebra.GeneralLinearGroup.Basic Mathlib.LinearAlgebra.GeneralLinearGroup
1

Declarations diff

+ mem_center_iff
+ mem_submonoidCenter_iff
+ mem_subsemigroupCenter_iff
+ smulLeft
+ smulLeft_eq

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@ocfnash ocfnash added the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 2, 2026
@ocfnash ocfnash self-assigned this Jan 2, 2026
@themathqueen themathqueen removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 2, 2026
@ocfnash
Copy link
Contributor

ocfnash commented Jan 2, 2026

Thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 2, 2026

✌️ themathqueen can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 2, 2026
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Jan 2, 2026
@themathqueen
Copy link
Collaborator Author

@ocfnash, there's a AddMonoidHom.smulLeft function, so I thought maybe we should extend that. But this comes with an additional 8 file import (3% increase).

Revert?

@ocfnash
Copy link
Contributor

ocfnash commented Jan 2, 2026

@ocfnash, there's a AddMonoidHom.smulLeft function, so I thought maybe we should extend that. But this comes with an additional 8 file import (3% increase).

Revert?

Oh yeah, I think not worth the 3% hit just to extend something trivial. No harm leaving some breadcrumbs between the two in the form of doc string comments if you like.

@github-actions github-actions bot removed the large-import Automatically added label for PRs with a significant increase in transitive imports label Jan 2, 2026
@themathqueen themathqueen added auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. and removed auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. labels Jan 2, 2026
@themathqueen
Copy link
Collaborator Author

bors r+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 2, 2026

Pull request successfully merged into master.

Build succeeded!

And happy new year! 🎉

@mathlib-bors mathlib-bors bot changed the title chore(Algebra/Central/End): generalize Algebra.IsCentral.instEnd [Merged by Bors] - chore(Algebra/Central/End): generalize Algebra.IsCentral.instEnd Jan 2, 2026
@mathlib-bors mathlib-bors bot closed this Jan 2, 2026
@themathqueen themathqueen deleted the gen_center_end branch January 2, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants