-
Notifications
You must be signed in to change notification settings - Fork 990
[Merged by Bors] - chore(Algebra/Central/End): generalize Algebra.IsCentral.instEnd
#33301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Algebra/Central/End): generalize Algebra.IsCentral.instEnd
#33301
Conversation
PR summary 51192f7a45
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Module.LinearMap.End | 276 | 277 | +1 (+0.36%) |
| Mathlib.Algebra.Central.End | 811 | 812 | +1 (+0.12%) |
Import changes for all files
| Files | Import difference |
|---|---|
19 filesMathlib.Algebra.Category.Grp.ZModuleEquivalence Mathlib.Algebra.Category.ModuleCat.Basic Mathlib.Algebra.Category.ModuleCat.Colimits Mathlib.Algebra.Category.ModuleCat.FilteredColimits Mathlib.Algebra.Category.ModuleCat.Semi Mathlib.Algebra.Central.End Mathlib.Algebra.Module.Equiv.Basic Mathlib.Algebra.Module.LinearMap.End Mathlib.Algebra.Order.Module.Equiv Mathlib.CategoryTheory.Abelian.GrothendieckCategory.Coseparator Mathlib.CategoryTheory.Adjunction.Additive Mathlib.CategoryTheory.Generator.Abelian Mathlib.CategoryTheory.Generator.Preadditive Mathlib.CategoryTheory.Limits.ConcreteCategory.WithAlgebraicStructures Mathlib.CategoryTheory.Linear.Yoneda Mathlib.CategoryTheory.Preadditive.Yoneda.Basic Mathlib.LinearAlgebra.Finsupp.Defs Mathlib.LinearAlgebra.GeneralLinearGroup.Basic Mathlib.LinearAlgebra.GeneralLinearGroup |
1 |
Declarations diff
+ mem_center_iff
+ mem_submonoidCenter_iff
+ mem_subsemigroupCenter_iff
+ smulLeft
+ smulLeft_eq
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
|
Thanks! bors d+ |
|
✌️ themathqueen can now approve this pull request. To approve and merge a pull request, simply reply with |
|
@ocfnash, there's a AddMonoidHom.smulLeft function, so I thought maybe we should extend that. But this comes with an additional 8 file import (3% increase). Revert? |
Oh yeah, I think not worth the 3% hit just to extend something trivial. No harm leaving some breadcrumbs between the two in the form of doc string comments if you like. |
|
bors r+ |
|
Pull request successfully merged into master. Build succeeded! And happy new year! 🎉 |
Algebra.IsCentral.instEndAlgebra.IsCentral.instEnd
This came up during review of #33282.