Skip to content

Conversation

@vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Dec 27, 2025

Upstreamed from the CGT repo.


Open in Gitpod

@github-actions
Copy link

github-actions bot commented Dec 27, 2025

PR summary f160a5e20b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ stdPart_nonneg
+ stdPart_nonpos
- ordConnected_preimage_mk'

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.02)
Current number Change Type
1506 -1 backwards compatibility flags
1478 -1 privateInPublic flags
50 -1 adaptation notes

Current commit e4193e7ffb
Reference commit f160a5e20b

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Dec 27, 2025
@vihdzp vihdzp requested a review from wwylele December 28, 2025 01:49
Co-authored-by: Weiyi Wang <wwylele@gmail.com>
@vihdzp vihdzp requested a review from YaelDillies December 28, 2025 03:44
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

This had been private, but while disabling `set_option backward.privateInPublic` as a global option
we have made it public again. -/
theorem ordConnected_preimage_mk' : ∀ x, Set.OrdConnected <| Quotient.mk
private theorem ordConnected_preimage_mk' : ∀ x, Set.OrdConnected <| Quotient.mk
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changed here?

Copy link
Collaborator Author

@vihdzp vihdzp Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made it private as it was supposed to be; all it took was adding by exact a few lines down. Note that ordConnected_preimage_mk is the public version of this declaration.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you let know whoever removed this private?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this was a largely automated task done by @jcommelin in #33034.

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 28, 2025
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Dec 29, 2025
mathlib-bors bot pushed a commit that referenced this pull request Dec 29, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 29, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: more lemmas on ArchimedeanClass.stdPart [Merged by Bors] - feat: more lemmas on ArchimedeanClass.stdPart Dec 29, 2025
@mathlib-bors mathlib-bors bot closed this Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants