-
Notifications
You must be signed in to change notification settings - Fork 974
[Merged by Bors] - feat: more lemmas on ArchimedeanClass.stdPart
#33343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR summary f160a5e20bImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type |
|---|---|---|
| 1506 | -1 | backwards compatibility flags |
| 1478 | -1 | privateInPublic flags |
| 50 | -1 | adaptation notes |
Current commit e4193e7ffb
Reference commit f160a5e20b
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Co-authored-by: Weiyi Wang <wwylele@gmail.com>
YaelDillies
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
maintainer delegate
| This had been private, but while disabling `set_option backward.privateInPublic` as a global option | ||
| we have made it public again. -/ | ||
| theorem ordConnected_preimage_mk' : ∀ x, Set.OrdConnected <| Quotient.mk | ||
| private theorem ordConnected_preimage_mk' : ∀ x, Set.OrdConnected <| Quotient.mk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What changed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just made it private as it was supposed to be; all it took was adding by exact a few lines down. Note that ordConnected_preimage_mk is the public version of this declaration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you let know whoever removed this private?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this was a largely automated task done by @jcommelin in #33034.
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Vierkantor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors r+
Upstreamed from the CGT repo.
|
Pull request successfully merged into master. Build succeeded: |
ArchimedeanClass.stdPartArchimedeanClass.stdPart
Upstreamed from the CGT repo.