Skip to content

Conversation

@vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Dec 28, 2025

We also deprecate some injective_foo lemmas in favor of foo_injective counterparts, as per the naming conventions.


Open in Gitpod

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Dec 28, 2025
@github-actions
Copy link

github-actions bot commented Dec 28, 2025

PR summary d68c4dc09f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ add_le_add_iff_left_of_ne_top
+ add_le_add_iff_right_of_ne_top
+ add_left_inj_of_ne_top
+ add_left_injective_of_ne_top
+ add_left_strictMono_of_ne_top
+ add_lt_add_iff_left_of_ne_top
+ add_lt_add_iff_right_of_ne_top
+ add_right_inj_of_ne_top
+ add_right_injective_of_ne_top
+ add_right_strictMono_of_ne_top
+ sub_le_sub_iff_left_of_ne_top
+ sub_left_inj_of_ne_top
+ sub_left_injective_of_ne_top
+ sub_left_strictMono_of_ne_top
+ sub_lt_sub_iff_left_of_ne_top
+ sub_right_inj_of_ne_top
+ sub_right_injective_of_ne_top

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@vihdzp vihdzp requested a review from YaelDillies December 28, 2025 00:07
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 28, 2025
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Dec 29, 2025
mathlib-bors bot pushed a commit that referenced this pull request Dec 29, 2025
…mmas (#33349)

We also deprecate some `injective_foo` lemmas in favor of `foo_injective` counterparts, as per the naming conventions.
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 29, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 29, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Order/AddGroupWithTop): more monotonicity/injectivity lemmas [Merged by Bors] - feat(Algebra/Order/AddGroupWithTop): more monotonicity/injectivity lemmas Dec 29, 2025
@mathlib-bors mathlib-bors bot closed this Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants