Skip to content

Conversation

@sun123zxy
Copy link
Contributor


Split from PR #33247

Open in Gitpod

@github-actions github-actions bot added new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-ring-theory Ring theory labels Dec 28, 2025
@github-actions
Copy link

github-actions bot commented Dec 28, 2025

PR summary e78e242c45

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ eq_of_map_mkQ_eq_map_mkQ_of_le_jacobson_bot
+ exists_injOn_mkQ_image_span_eq_of_span_eq_map_mkQ_of_le_jacobson_bot
+ le_of_map_mkQ_le_map_mkQ_of_le_jacobson_bot

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@erdOne erdOne added the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 3, 2026
@sun123zxy
Copy link
Contributor Author

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 3, 2026
@sun123zxy
Copy link
Contributor Author

I don't understand why CI fails after adding the deprecation tag. Is this supposed to happen?

@erdOne
Copy link
Member

erdOne commented Jan 3, 2026

I have no idea as well. Try merging master?

@erdOne
Copy link
Member

erdOne commented Jan 3, 2026

Thanks!
maintainer merge

@github-actions
Copy link

github-actions bot commented Jan 3, 2026

🚀 Pull request has been placed on the maintainer queue by erdOne.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants