Skip to content

Conversation

@chenson2018
Copy link
Collaborator

Closes #172. This PR moves CSLib to the module system, mostly following Mathlib's pattern of using @[expose] public section liberally for the simplest transition. This removes a few uses of private that conflicted:

  • LTS.noε
  • the HasTau instance in Cslib.Computability.Automata.EpsilonNA.Basic
  • grind lemmas about ReductionSystem
  • FinFun.fromFun

I also think it might be less confusing if we move some meta sections to their own files, but will leave this for a future PR.

@chenson2018 chenson2018 requested a review from fmontesi as a code owner January 3, 2026 17:19
@chenson2018 chenson2018 requested a review from kim-em as a code owner January 3, 2026 17:26
@chenson2018
Copy link
Collaborator Author

For the moment I have moved lake exe mk_all --check --module into its own step, because lean-action does not yet have a parameter for this. (I can make a PR for this later, but don't want it to hold up this one)

@chenson2018
Copy link
Collaborator Author

I have also removed the shake step, as my understanding is that this is not yet compatible with the module system. (Though I think we can still encourage people to use #min_imports until the replacement is in effect.)

@fmontesi fmontesi added this pull request to the merge queue Jan 12, 2026
Merged via the queue into leanprover:main with commit d61818c Jan 12, 2026
2 checks passed
@arademaker
Copy link
Collaborator

I have also removed the shake step, as my understanding is that this is not yet compatible with the module system. (Though I think we can still encourage people to use #min_imports until the replacement is in effect.)

This is confusing to me. In one of Lean office hours, @Kha mentioned a version of Shake compatible with the new module system. Here I am using a particular version that @Kha mentioned and I copied to this repo. But I now seens to be moved to https://github.com/leanprover/lean4/blob/master/src/lake/Lake/CLI/Shake.lean.

@chenson2018
Copy link
Collaborator Author

My understanding is that this will be available downstream in the next release candidate (and currently in nightly testing), now accessed directly via lake shake. As soon as this happens, I will restore this step in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move to the module system

3 participants