Skip to content

Conversation

@mrpau-eugene
Copy link
Contributor

Summary

@radinamatic suggested to unify the Color Legends together with the Keys

Issues addressed

List the issues solved or partly solved by the PR
#5510
#5494

@mrpau-eugene mrpau-eugene added this to the 0.17.3 milestone Aug 30, 2017
@mrpau-eugene mrpau-eugene self-assigned this Aug 30, 2017
@codecov
Copy link

codecov bot commented Aug 30, 2017

Codecov Report

Merging #5511 into 0.17.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.17.x    #5511   +/-   ##
=======================================
  Coverage   62.77%   62.77%           
=======================================
  Files         117      117           
  Lines        6555     6555           
=======================================
  Hits         4115     4115           
  Misses       2440     2440
Impacted Files Coverage Δ
kalite/distributed/views.py 78.65% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c068e2...266c81b. Read the comment docs.

@benjaoming benjaoming modified the milestones: 0.17.3, 0.17.4 Aug 30, 2017
@radinamatic
Copy link
Member

I wasn't able to confirm this fix @mrpau-eugene 😞

Buildkite does not compile installers by default for PRs, I tried (and failed 3 times) to initiate the build myself (Buildkite 3, Radina 0 😡).

Then I tried applying the changes from your PR on the VM installations in both Ubuntu (rc2-2) and Windows (dev build from last week). collectstatic was successful on Ubuntu, but not on Windows install, and no changes were visible anywhere.

I might be missing something, could you build the installer so I could test?

@mrpau-eugene
Copy link
Contributor Author

mrpau-eugene commented Aug 31, 2017

@radinamatic can you download and test this installer here?

@benjaoming benjaoming modified the milestones: 0.17.3, 0.17.4 Aug 31, 2017
@benjaoming
Copy link
Contributor

Sorry, I can see that it will be pretty annoying to communicate what's going on to someone reading our release notes.

Am merging this for 0.17.3.

Will test.

@benjaoming benjaoming merged commit bdddd9e into learningequality:0.17.x Aug 31, 2017
@mrpau-eugene mrpau-eugene deleted the hotfix/5510-unify-color-legends-on-teach-page branch November 16, 2017 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants