Ensure we use options.ini configuration for port selection. #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtibbles
force-pushed
the
pass_the_port_to_the_left
branch
from
c6894f2 to
f23255a
Compare
rtibbles
force-pushed
the
pass_the_port_to_the_left
branch
from
f23255a to
e4a1e74
Compare
marcellamaki
approved these changes
May 1, 2024
Member
marcellamaki
left a comment
marcellamaki
left a comment
There was a problem hiding this comment.
looks good, and manual testing confirms that it works as expected on 8080 (and also as expected - not working - on another unused random port)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112